Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Side by Side Diff: chrome/browser/ui/views/chrome_views_delegate.cc

Issue 108193005: Fixing opacity for browser frame window on ASH/Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ChromeOS build changes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/chrome_views_delegate.h" 5 #include "chrome/browser/ui/views/chrome_views_delegate.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/prefs/scoped_user_pref_update.h" 9 #include "base/prefs/scoped_user_pref_update.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 168
169 views::NonClientFrameView* ChromeViewsDelegate::CreateDefaultNonClientFrameView( 169 views::NonClientFrameView* ChromeViewsDelegate::CreateDefaultNonClientFrameView(
170 views::Widget* widget) { 170 views::Widget* widget) {
171 #if defined(USE_ASH) 171 #if defined(USE_ASH)
172 if (chrome::IsNativeViewInAsh(widget->GetNativeView())) 172 if (chrome::IsNativeViewInAsh(widget->GetNativeView()))
173 return ash::Shell::GetInstance()->CreateDefaultNonClientFrameView(widget); 173 return ash::Shell::GetInstance()->CreateDefaultNonClientFrameView(widget);
174 #endif 174 #endif
175 return NULL; 175 return NULL;
176 } 176 }
177 177
178 bool ChromeViewsDelegate::UseTransparentWindows() const {
179 #if defined(USE_ASH)
180 // TODO(scottmg): http://crbug.com/133312. This needs context to determine
181 // if it's desktop or ash.
182 #if defined(OS_CHROMEOS)
183 return true;
184 #else
185 NOTIMPLEMENTED();
186 return false;
187 #endif
188 #else
189 return false;
190 #endif
191 }
192
193 void ChromeViewsDelegate::AddRef() { 178 void ChromeViewsDelegate::AddRef() {
194 g_browser_process->AddRefModule(); 179 g_browser_process->AddRefModule();
195 } 180 }
196 181
197 void ChromeViewsDelegate::ReleaseRef() { 182 void ChromeViewsDelegate::ReleaseRef() {
198 g_browser_process->ReleaseModule(); 183 g_browser_process->ReleaseModule();
199 } 184 }
200 185
201 content::WebContents* ChromeViewsDelegate::CreateWebContents( 186 content::WebContents* ChromeViewsDelegate::CreateWebContents(
202 content::BrowserContext* browser_context, 187 content::BrowserContext* browser_context,
203 content::SiteInstance* site_instance) { 188 content::SiteInstance* site_instance) {
204 return NULL; 189 return NULL;
205 } 190 }
206 191
207 void ChromeViewsDelegate::OnBeforeWidgetInit( 192 void ChromeViewsDelegate::OnBeforeWidgetInit(
208 views::Widget::InitParams* params, 193 views::Widget::InitParams* params,
209 views::internal::NativeWidgetDelegate* delegate) { 194 views::internal::NativeWidgetDelegate* delegate) {
195 // We need to determine opacity if it's not already specified.
196 if (params->opacity == views::Widget::InitParams::INFER_OPACITY)
197 params->opacity = GetOpacityForInitParams(*params);
198
210 // If we already have a native_widget, we don't have to try to come 199 // If we already have a native_widget, we don't have to try to come
211 // up with one. 200 // up with one.
212 if (params->native_widget) 201 if (params->native_widget)
213 return; 202 return;
214 203
215 #if defined(USE_AURA) && !defined(OS_CHROMEOS) 204 #if defined(USE_AURA) && !defined(OS_CHROMEOS)
216 bool use_non_toplevel_window = 205 bool use_non_toplevel_window =
217 params->parent && params->type != views::Widget::InitParams::TYPE_MENU; 206 params->parent && params->type != views::Widget::InitParams::TYPE_MENU;
218 207
219 #if defined(OS_WIN) 208 #if defined(OS_WIN)
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 params->native_widget = new views::DesktopNativeWidgetAura(delegate); 293 params->native_widget = new views::DesktopNativeWidgetAura(delegate);
305 } 294 }
306 } 295 }
307 #endif 296 #endif
308 } 297 }
309 298
310 base::TimeDelta 299 base::TimeDelta
311 ChromeViewsDelegate::GetDefaultTextfieldObscuredRevealDuration() { 300 ChromeViewsDelegate::GetDefaultTextfieldObscuredRevealDuration() {
312 return base::TimeDelta(); 301 return base::TimeDelta();
313 } 302 }
303
304 #if !defined(USE_AURA) && !defined(USE_CHROMEOS)
305 views::Widget::InitParams::WindowOpacity
306 ChromeViewsDelegate::GetOpacityForInitParams(
307 const views::Widget::InitParams& params) {
308 return views::Widget::InitParams::OPAQUE_WINDOW;
309 }
310 #endif
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/chrome_views_delegate.h ('k') | chrome/browser/ui/views/chrome_views_delegate_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698