chrome/browser/ui/views/chrome_views_delegate_chromeos.cc - Issue 108193005: Fixing opacity for browser frame window on ASH/Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/chrome_views_delegate_chromeos.cc

Issue 108193005: Fixing opacity for browser frame window on ASH/Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Further minor changes Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/views/chrome_views_delegate.h"

	6

	7 #if defined(USE_CHROMEOS)
	sky 2013/12/17 15:59:00 You shouldn't need an ifdef here. You shouldn't need an ifdef here. Shrikant Kelkar 2013/12/17 18:01:00 Done. Show quoted text On 2013/12/17 15:59:00, sky wrote: > You shouldn't need an ifdef here. Done.
	8 views::Widget::InitParams::WindowOpacity

	9 ChromeViewsDelegate::InferOpacity(views::Widget::InitParams* params) {

	10 if (params->type != views::Widget::InitParams::TYPE_WINDOW &&

	11 params->type != views::Widget::InitParams::TYPE_PANEL)

	12 // All other windows except TYPE_WINDOW AND TYPE_PANEL should be
	sky 2013/12/17 15:59:00 This comment isn't helpful since it just documents This comment isn't helpful since it just documents what the code does. Comments should describe why the code is the way it is. Shrikant Kelkar 2013/12/17 18:01:00 Done. Show quoted text On 2013/12/17 15:59:00, sky wrote: > This comment isn't helpful since it just documents what the code does. Comments > should describe why the code is the way it is. Done.
	13 // opaque.

	14 return views::Widget::InitParams::OPAQUE_WINDOW;

	15 return params->opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;

	16 }

	17 #endif

OLD	NEW