chrome/browser/ui/views/chrome_views_delegate.h - Issue 108193005: Fixing opacity for browser frame window on ASH/Windows.

Side by Side Diff: chrome/browser/ui/views/chrome_views_delegate.h

Issue 108193005: Fixing opacity for browser frame window on ASH/Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Further minor changes Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « ash/shell/content_client/shell_browser_main_parts.cc ('k') | chrome/browser/ui/views/chrome_views_delegate.cc » ('j') | chrome/browser/ui/views/chrome_views_delegate.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_

6 #define CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_	6 #define CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "build/build_config.h"	10 #include "build/build_config.h"

(...skipping 24 matching lines...) Expand all Loading...
35 bool has_submenu) OVERRIDE;	35 bool has_submenu) OVERRIDE;

36	36

37 #if defined(OS_WIN)	37 #if defined(OS_WIN)

38 virtual HICON GetDefaultWindowIcon() const OVERRIDE;	38 virtual HICON GetDefaultWindowIcon() const OVERRIDE;

39 virtual bool IsWindowInMetro(gfx::NativeWindow window) const OVERRIDE;	39 virtual bool IsWindowInMetro(gfx::NativeWindow window) const OVERRIDE;

40 #elif defined(OS_LINUX) && !defined(OS_CHROMEOS)	40 #elif defined(OS_LINUX) && !defined(OS_CHROMEOS)

41 virtual gfx::ImageSkia* GetDefaultWindowIcon() const OVERRIDE;	41 virtual gfx::ImageSkia* GetDefaultWindowIcon() const OVERRIDE;

42 #endif	42 #endif

43 virtual views::NonClientFrameView* CreateDefaultNonClientFrameView(	43 virtual views::NonClientFrameView* CreateDefaultNonClientFrameView(

44 views::Widget* widget) OVERRIDE;	44 views::Widget* widget) OVERRIDE;

45 virtual bool UseTransparentWindows() const OVERRIDE;

46 virtual void AddRef() OVERRIDE;	45 virtual void AddRef() OVERRIDE;

47 virtual void ReleaseRef() OVERRIDE;	46 virtual void ReleaseRef() OVERRIDE;

48 virtual content::WebContents* CreateWebContents(	47 virtual content::WebContents* CreateWebContents(

49 content::BrowserContext* browser_context,	48 content::BrowserContext* browser_context,

50 content::SiteInstance* site_instance) OVERRIDE;	49 content::SiteInstance* site_instance) OVERRIDE;

51 virtual void OnBeforeWidgetInit(	50 virtual void OnBeforeWidgetInit(

52 views::Widget::InitParams* params,	51 views::Widget::InitParams* params,

53 views::internal::NativeWidgetDelegate* delegate) OVERRIDE;	52 views::internal::NativeWidgetDelegate* delegate) OVERRIDE;

54 virtual base::TimeDelta GetDefaultTextfieldObscuredRevealDuration() OVERRIDE;	53 virtual base::TimeDelta GetDefaultTextfieldObscuredRevealDuration() OVERRIDE;

55	54

56 private:	55 private:

	56 views::Widget::InitParams::WindowOpacity InferOpacity(

	57 views::Widget::InitParams* params);
	sky 2013/12/17 15:59:00 How about naming this GetWindowOpacity and make it How about naming this GetWindowOpacity and make it take a const InitParams&. Shrikant Kelkar 2013/12/17 18:01:00 Done. Show quoted text On 2013/12/17 15:59:00, sky wrote: > How about naming this GetWindowOpacity and make it take a const InitParams&. Done.
57 DISALLOW_COPY_AND_ASSIGN(ChromeViewsDelegate);	58 DISALLOW_COPY_AND_ASSIGN(ChromeViewsDelegate);
	sky 2013/12/17 15:59:00 nit: newline between 57/58 nit: newline between 57/58 Shrikant Kelkar 2013/12/17 18:01:00 Done. Show quoted text On 2013/12/17 15:59:00, sky wrote: > nit: newline between 57/58 Done.
58 };	59 };

59	60

60 #endif // CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_	61 #endif // CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_

OLD	NEW