Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1081923002: Remove PrerenderLocalPredictor, part 5. (Closed)

Created:
5 years, 8 months ago by davidben
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@prerender-local-predictor-4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PrerenderLocalPredictor, part 5. This removes history::BriefVisitInfo. It is now unused. BUG=471807 Committed: https://crrev.com/5954aaf89c97ce1cbd407ddbb5e206750a00b818 Cr-Commit-Position: refs/heads/master@{#325719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -77 lines) Patch
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/history/core/browser/history_backend.h View 2 chunks +0 lines, -7 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M components/history/core/browser/history_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/history/core/browser/history_service.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M components/history/core/browser/history_service_observer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/history/core/browser/history_types.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/history/core/browser/visit_database.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/history/core/browser/visit_database.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
mmenke found even more dead code. :-) This depends on https://codereview.chromium.org/1077433002/
5 years, 8 months ago (2015-04-13 16:39:25 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-13 19:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081923002/1
5 years, 8 months ago (2015-04-17 20:43:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 21:13:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 21:15:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5954aaf89c97ce1cbd407ddbb5e206750a00b818
Cr-Commit-Position: refs/heads/master@{#325719}

Powered by Google App Engine
This is Rietveld 408576698