Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: net/cert/cert_verify_proc.h

Issue 1081913003: Route OCSP stapling through CertVerifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@boringnss
Patch Set: yet another CrOS-only Verify call Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/cert_verifier.cc ('k') | net/cert/cert_verify_proc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc.h
diff --git a/net/cert/cert_verify_proc.h b/net/cert/cert_verify_proc.h
index 3cea884bc62b2c67c444033fb93eae2de88ca0fc..fdc1205b8495486952f0e851c187ba91241b8182 100644
--- a/net/cert/cert_verify_proc.h
+++ b/net/cert/cert_verify_proc.h
@@ -38,6 +38,8 @@ class NET_EXPORT CertVerifyProc
// |verify_result->cert_status|, and the error code for the most serious
// error is returned.
//
+ // |ocsp_response|, if non-empty, is a stapled OCSP response to use.
+ //
// |flags| is bitwise OR'd of VerifyFlags:
//
// If VERIFY_REV_CHECKING_ENABLED is set in |flags|, online certificate
@@ -56,6 +58,7 @@ class NET_EXPORT CertVerifyProc
// implementation.
int Verify(X509Certificate* cert,
const std::string& hostname,
+ const std::string& ocsp_response,
int flags,
CRLSet* crl_set,
const CertificateList& additional_trust_anchors,
@@ -66,6 +69,11 @@ class NET_EXPORT CertVerifyProc
// passed to Verify() is ignored when this returns false.
virtual bool SupportsAdditionalTrustAnchors() const = 0;
+ // Returns true if the implementation supports passing a stapled OCSP response
+ // to the Verify() call. The |ocsp_response| parameter passed to Verify() is
+ // ignored when this returns false.
+ virtual bool SupportsOCSPStapling() const = 0;
+
protected:
CertVerifyProc();
virtual ~CertVerifyProc();
@@ -81,6 +89,7 @@ class NET_EXPORT CertVerifyProc
// value must be left untouched.
virtual int VerifyInternal(X509Certificate* cert,
const std::string& hostname,
+ const std::string& ocsp_response,
int flags,
CRLSet* crl_set,
const CertificateList& additional_trust_anchors,
« no previous file with comments | « net/cert/cert_verifier.cc ('k') | net/cert/cert_verify_proc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698