IDL: Handle the [Unscopeable, RuntimeEnabled=X] combination better

IDL: Handle the [Unscopeable, RuntimeEnabled=X] combination better

If a runtime enabled attribute or method is unscopeable, then add it to
the @@unscopables object only if the feature is enabled. This is a
marginal change, but it does ensure that features don't leave detectable
artifacts when disabled.

BUG=462916
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194384

[Jens Widell, 2015-04-24 10:35:45]

jl@opera.com changed reviewers:
+ haraken@chromium.org

[Jens Widell, 2015-04-24 10:35:46]

PTAL

The likely first use of [Unscopeable] is Node.append() et al, that we may
potentially want to add behind a flag initially.

There could be an overlap with [Exposed] as well, in theory, but a) it's less
likely, I think, and b) if so, it'll still be a feature we have shipped, so
"leaking" some names in @@unscopables would be even less of a problem.

[haraken, 2015-04-24 10:42:59]

https://codereview.chromium.org/1081853003/diff/1/Source/bindings/scripts/v8_...
File Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/1081853003/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_interface.py:250:
unscopeables.append((attribute.name,
v8_utilities.runtime_enabled_function_name(attribute)))

What happens if we simply don't add not-runtime-enabled attributes to
|unscopeables| here? Is it hard to implement?

[Jens Widell, 2015-04-24 10:48:00]

https://codereview.chromium.org/1081853003/diff/1/Source/bindings/scripts/v8_...
File Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/1081853003/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_interface.py:250:
unscopeables.append((attribute.name,
v8_utilities.runtime_enabled_function_name(attribute)))
On 2015/04/24 10:42:59, haraken wrote:
> 
> What happens if we simply don't add not-runtime-enabled attributes to
> |unscopeables| here? Is it hard to implement?

This code runs compile-time. How would we know here whether something will be
enabled runtime?

[haraken, 2015-04-24 10:49:13]

LGTM

https://codereview.chromium.org/1081853003/diff/1/Source/bindings/scripts/v8_...
File Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/1081853003/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_interface.py:250:
unscopeables.append((attribute.name,
v8_utilities.runtime_enabled_function_name(attribute)))
On 2015/04/24 10:47:59, Jens Widell wrote:
> On 2015/04/24 10:42:59, haraken wrote:
> > 
> > What happens if we simply don't add not-runtime-enabled attributes to
> > |unscopeables| here? Is it hard to implement?
> 
> This code runs compile-time. How would we know here whether something will be
> enabled runtime?

ah, you're totally right :)

[Jens Widell, 2015-04-24 10:51:11]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2015-04-24 10:51:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1081853003/1

[commit-bot: I haz the power, 2015-04-24 12:10:24]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194384