Source/core/layout/svg/SVGTextLayoutEngine.cpp - Issue 1081813003: Remove effective zoom from font metrics before SVG text layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/SVGTextLayoutEngine.cpp

Issue 1081813003: Remove effective zoom from font metrics before SVG text layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/custom/zoomed-baseline-shift.html ('k') | Source/core/layout/svg/SVGTextLayoutEngineBaseline.h » ('j') | Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/svg/SVGTextLayoutEngine.cpp

diff --git a/Source/core/layout/svg/SVGTextLayoutEngine.cpp b/Source/core/layout/svg/SVGTextLayoutEngine.cpp

index 7df1f265651d83b7a6f4a6f3d3a083e8200c59e1..46c1109fb70ad7dd4b83058a900b407461ccd7f1 100644

--- a/Source/core/layout/svg/SVGTextLayoutEngine.cpp

+++ b/Source/core/layout/svg/SVGTextLayoutEngine.cpp

@@ -441,7 +441,7 @@ void SVGTextLayoutEngine::layoutTextOnLineOrPath(SVGInlineTextBox* textBox, cons

const Font& font = style.font();

SVGTextLayoutEngineSpacing spacingLayout(font, style.effectiveZoom());

- SVGTextLayoutEngineBaseline baselineLayout(font);

+ SVGTextLayoutEngineBaseline baselineLayout(font, style.effectiveZoom());

bool didStartTextFragment = false;

bool applySpacingToNextCharacter = false;