LayoutTests/svg/custom/zoomed-baseline-shift.html - Issue 1081813003: Remove effective zoom from font metrics before SVG text layout.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/zoomed-baseline-shift.html

Issue 1081813003: Remove effective zoom from font metrics before SVG text layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/svg/custom/zoomed-alignment-baseline.html ('k') | Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('j') | Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>Test that baseline-shift is unaffected by zoom level</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <svg width="250" height="140" viewBox="0 0 250 140"

	6 xmlns="http://www.w3.org/2000/svg" version="1.1">

	7 <style>

	8 text {

	9 font-family: ahem;

	10 font-size: 20px;

	11 }

	12 </style>

	13 <text x="15" y="40">before<tspan>inter</tspan>after</text>

	14 <script>

	15 var expectedHeight = 20 + 10; // font-size + half a step up or down

	16 var baselineShiftValues = ["sub", "super", "10px", "-50%" ]; // Shift half a step up or down

	17 var zoomLevels = [1, 4, 16];

	18 var html = document.documentElement;

	19 baselineShiftValues.forEach(function (baselineShiftValue) {

	20 document.querySelector('tspan').setAttribute('baseline-shift', baselineS hiftValue);

	21 zoomLevels.forEach(function (zoom) {

	22 html.style.zoom = zoom;

	23 var bounds = document.querySelector('text').getBoundingClientRect();

	24 test(function () {

	25 assert_equals(bounds.height, expectedHeight);

	26 }, "text bound height at zoom " + zoom + " with baseline-shift=" + b aselineShiftValue);

	27 });

	28 });

	29 html.style.zoom = 1;

	30 </script>

	31 </svg>

	32 <p>This test requires the Ahem font</p>

OLD	NEW