Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1081803005: Fix warnings and errors in ChromeVox since Closure compiler update. (Closed)

Created:
5 years, 8 months ago by David Tseng
Modified:
5 years, 8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix warnings and errors in ChromeVox since Closure compiler update. Committed: https://crrev.com/113bbd3d53d5061316a1d00749416dfcc208265b Cr-Commit-Position: refs/heads/master@{#326828}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
David Tseng
5 years, 8 months ago (2015-04-24 16:55:14 UTC) #2
dmazzoni
lgtm
5 years, 8 months ago (2015-04-24 17:04:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081803005/1
5 years, 8 months ago (2015-04-24 17:04:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 17:37:22 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 17:38:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/113bbd3d53d5061316a1d00749416dfcc208265b
Cr-Commit-Position: refs/heads/master@{#326828}

Powered by Google App Engine
This is Rietveld 408576698