Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 108173008: Linux Sandbox: check no threads before fork(). (Closed)

Created:
7 years ago by jln (very slow on Chromium)
Modified:
7 years ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux Sandbox: check no threads before fork(). Always check that no threads are running before fork(). BUG=327241 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239894

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nits. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M sandbox/linux/services/broker_process.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jln (very slow on Chromium)
Jorge, please take a look at this tiny CL!
7 years ago (2013-12-10 20:03:05 UTC) #1
Jorge Lucangeli Obes
lgtm https://codereview.chromium.org/108173008/diff/1/sandbox/linux/seccomp-bpf/sandbox_bpf.cc File sandbox/linux/seccomp-bpf/sandbox_bpf.cc (right): https://codereview.chromium.org/108173008/diff/1/sandbox/linux/seccomp-bpf/sandbox_bpf.cc#newcode271 sandbox/linux/seccomp-bpf/sandbox_bpf.cc:271: // This code is using fork() and should ...
7 years ago (2013-12-10 21:14:08 UTC) #2
jln (very slow on Chromium)
https://codereview.chromium.org/108173008/diff/1/sandbox/linux/seccomp-bpf/sandbox_bpf.cc File sandbox/linux/seccomp-bpf/sandbox_bpf.cc (right): https://codereview.chromium.org/108173008/diff/1/sandbox/linux/seccomp-bpf/sandbox_bpf.cc#newcode271 sandbox/linux/seccomp-bpf/sandbox_bpf.cc:271: // This code is using fork() and should only ...
7 years ago (2013-12-10 21:42:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/108173008/10001
7 years ago (2013-12-10 21:44:13 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-10 22:31:00 UTC) #5
Message was sent while issue was closed.
Change committed as 239894

Powered by Google App Engine
This is Rietveld 408576698