Chromecast startup race: don't add filter before HostResolver exists.

chromecast/browser/cast_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_browser_main_parts.h"
 
 #if !defined(OS_ANDROID)
 #include <signal.h>
 #include <sys/prctl.h>
 #endif
@@ skipping 16 matching lines @@
 #include "chromecast/browser/pref_service_helper.h"
 #include "chromecast/browser/service/cast_service.h"
 #include "chromecast/browser/url_request_context_factory.h"
 #include "chromecast/common/chromecast_switches.h"
 #include "chromecast/common/platform_client_auth.h"
 #include "chromecast/net/connectivity_checker.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/content_switches.h"
 #include "media/base/browser_cdm_factory.h"
 #include "media/base/media_switches.h"
+#include "net/url_request/url_request_context_getter.h"
 
 #if defined(OS_ANDROID)
 #include "chromecast/crash/android/crash_handler.h"
 #include "components/crash/browser/crash_dump_manager_android.h"
 #include "net/android/network_change_notifier_factory_android.h"
 #else
 #include "chromecast/browser/media/cast_browser_cdm_factory.h"
 #endif
 
 #if defined(USE_AURA)
@@ skipping 219 matching lines @@
   if (cmd_line->HasSwitch(switches::kEnableCmaMediaPipeline))
     ::media::SetBrowserCdmFactory(new media::CastBrowserCdmFactory);
 #endif  // !defined(OS_ANDROID)
 
   cast_browser_process_->SetConnectivityChecker(
       make_scoped_refptr(new ConnectivityChecker(
           content::BrowserThread::GetMessageLoopProxyForThread(
               content::BrowserThread::IO))));
 
   url_request_context_factory_->InitializeOnUIThread();
+  // Forcibly trigger I/O-thread initialization.
+  content::BrowserThread::PostTask(
+      content::BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(base::IgnoreResult(
+                     &net::URLRequestContextGetter::GetURLRequestContext),
+                 base::Unretained(
+                     url_request_context_factory_->GetSystemGetter())));

[byungchul, 2015/04/17 17:56:17]

I would call this in CastContentBrowserClient::RenderProcessWillLaunch(). You
can replace the first callback PostTaskAndReplyWithResult() with this callback.
It is better to put related logic in one place.

[gunsch, 2015/04/17 18:24:42]

SGTM. I think CastContentBrowserClient is the only place where we have this
thread-race dependency, so putting this there seems reasonable. If we had it in
more places I might prefer to move the logic here.

 
   cast_browser_process_->SetBrowserContext(
       make_scoped_ptr(new CastBrowserContext(url_request_context_factory_)));
   cast_browser_process_->SetMetricsServiceClient(
       metrics::CastMetricsServiceClient::Create(
           content::BrowserThread::GetBlockingPool(),
           cast_browser_process_->pref_service(),
           cast_browser_process_->browser_context()->GetRequestContext()));
 
   if (!PlatformClientAuth::Initialize())
@@ skipping 56 matching lines @@
 #else
   cast_browser_process_->cast_service()->Finalize();
   cast_browser_process_->metrics_service_client()->Finalize();
   cast_browser_process_.reset();
   DeregisterKillOnAlarm();
 #endif
 }
 
 }  // namespace shell
 }  // namespace chromecast