Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2254)

Unified Diff: Source/modules/accessibility/AXObjectCacheImpl.h

Issue 1081673003: Oilpan: Prepare to move AXObjectCache to the heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXObjectCacheImpl.h
diff --git a/Source/modules/accessibility/AXObjectCacheImpl.h b/Source/modules/accessibility/AXObjectCacheImpl.h
index 8d85fc2fa8f9ffff601396af62966c34ed3a1c96..a746643f83e48be0d38f977a64bab065fda185e9 100644
--- a/Source/modules/accessibility/AXObjectCacheImpl.h
+++ b/Source/modules/accessibility/AXObjectCacheImpl.h
@@ -55,15 +55,19 @@ struct TextMarkerData {
// This class should only be used from inside the accessibility directory.
class MODULES_EXPORT AXObjectCacheImpl : public AXObjectCache {
- WTF_MAKE_NONCOPYABLE(AXObjectCacheImpl); WTF_MAKE_FAST_ALLOCATED(AXObjectCacheImpl);
+ WTF_MAKE_NONCOPYABLE(AXObjectCacheImpl);
+ WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(AXObjectCacheImpl);
haraken 2015/05/29 09:16:19 I think you can just remove this, since we have WT
keishi 2015/06/08 06:27:52 Done.
public:
- static PassOwnPtr<AXObjectCache> create(Document&);
+ static PassOwnPtrWillBeRawPtr<AXObjectCache> create(Document&);
explicit AXObjectCacheImpl(Document&);
~AXObjectCacheImpl();
+ DECLARE_VIRTUAL_TRACE();
AXObject* focusedUIElementForPage(const Page*);
+ virtual void dispose() override;
+
virtual void selectionChanged(Node*) override;
virtual void childrenChanged(Node*) override;
virtual void childrenChanged(LayoutObject*) override;
@@ -213,6 +217,11 @@ private:
HashSet<AXID> m_idsInUse;
+#if ENABLE(ASSERT)
+ // Verified when finalizing.
+ bool m_hasBeenDisposed;
+#endif
+
//
// Aria-owns
//

Powered by Google App Engine
This is Rietveld 408576698