Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1081673003: Oilpan: Prepare to move AXObjectCache to the heap (Closed)

Created:
5 years, 8 months ago by keishi
Modified:
5 years, 6 months ago
CC:
blink-reviews, je_julie(Not used), aboxhall, sof, eae+blinkwatch, dglazkov+blink, blink-reviews-dom_chromium.org, nektarios, dmazzoni, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Prepare to move AXObjectCache to the heap  ScopedAXObjectCache is only used one place at a time so it doesn't need to be a RefCounted. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197561

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 12

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Total comments: 3

Patch Set 10 : #

Total comments: 6

Patch Set 11 : #

Patch Set 12 : #

Total comments: 8

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -52 lines) Patch
M Source/core/dom/AXObjectCache.h View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +14 lines, -10 lines 0 comments Download
M Source/core/dom/AXObjectCache.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +16 lines, -19 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +4 lines, -8 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +10 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +20 lines, -2 lines 0 comments Download
M Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebAXObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 29 (6 generated)
keishi
Depends on Refactor ScopedAXObjectCache to remove ref count ( https://codereview.chromium.org/1088473002/ )
5 years, 8 months ago (2015-04-28 06:19:36 UTC) #2
kouhei (in TOK)
lgtm
5 years, 8 months ago (2015-04-28 07:31:54 UTC) #3
haraken
https://codereview.chromium.org/1081673003/diff/100001/Source/core/dom/AXObjectCache.h File Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1081673003/diff/100001/Source/core/dom/AXObjectCache.h#newcode148 Source/core/dom/AXObjectCache.h:148: class CORE_EXPORT ScopedAXObjectCache { Can we make this GarbageCollected? ...
5 years, 7 months ago (2015-04-28 10:45:21 UTC) #4
keishi
https://codereview.chromium.org/1081673003/diff/100001/Source/core/dom/AXObjectCache.h File Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1081673003/diff/100001/Source/core/dom/AXObjectCache.h#newcode148 Source/core/dom/AXObjectCache.h:148: class CORE_EXPORT ScopedAXObjectCache { On 2015/04/28 10:45:20, haraken wrote: ...
5 years, 7 months ago (2015-05-28 06:49:15 UTC) #5
haraken
Maybe I should have suggested this earlier but... https://codereview.chromium.org/1081673003/diff/160001/Source/core/dom/AXObjectCache.h File Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1081673003/diff/160001/Source/core/dom/AXObjectCache.h#newcode148 Source/core/dom/AXObjectCache.h:148: class ...
5 years, 7 months ago (2015-05-28 08:57:57 UTC) #6
dmazzoni
On Thu, May 28, 2015 at 1:57 AM, <haraken@chromium.org> wrote: > Is ScopedAXObjectCache used in ...
5 years, 6 months ago (2015-05-28 15:10:09 UTC) #7
keishi
https://codereview.chromium.org/1081673003/diff/160001/Source/core/dom/AXObjectCache.h File Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1081673003/diff/160001/Source/core/dom/AXObjectCache.h#newcode148 Source/core/dom/AXObjectCache.h:148: class CORE_EXPORT ScopedAXObjectCache : public NoBaseWillBeGarbageCollectedFinalized<ScopedAXObjectCache> { On 2015/05/28 ...
5 years, 6 months ago (2015-05-29 09:00:57 UTC) #8
haraken
https://codereview.chromium.org/1081673003/diff/180001/Source/core/dom/AXObjectCache.h File Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1081673003/diff/180001/Source/core/dom/AXObjectCache.h#newcode162 Source/core/dom/AXObjectCache.h:162: RawPtrWillBePersistent<AXObjectCache> m_cache; RawPtrWillBePersistent is a bit concerning since it ...
5 years, 6 months ago (2015-05-29 09:16:19 UTC) #9
keishi
https://codereview.chromium.org/1081673003/diff/180001/Source/core/dom/AXObjectCache.h File Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1081673003/diff/180001/Source/core/dom/AXObjectCache.h#newcode162 Source/core/dom/AXObjectCache.h:162: RawPtrWillBePersistent<AXObjectCache> m_cache; On 2015/05/29 09:16:19, haraken wrote: > > ...
5 years, 6 months ago (2015-06-08 06:27:52 UTC) #11
haraken
On 2015/06/08 06:27:52, keishi wrote: > https://codereview.chromium.org/1081673003/diff/180001/Source/core/dom/AXObjectCache.h > File Source/core/dom/AXObjectCache.h (right): > > https://codereview.chromium.org/1081673003/diff/180001/Source/core/dom/AXObjectCache.h#newcode162 > ...
5 years, 6 months ago (2015-06-08 06:39:59 UTC) #12
keishi
On 2015/06/08 06:39:59, haraken wrote: > On 2015/06/08 06:27:52, keishi wrote: > > > https://codereview.chromium.org/1081673003/diff/180001/Source/core/dom/AXObjectCache.h ...
5 years, 6 months ago (2015-06-08 06:42:24 UTC) #13
haraken
On 2015/06/08 06:42:24, keishi wrote: > On 2015/06/08 06:39:59, haraken wrote: > > On 2015/06/08 ...
5 years, 6 months ago (2015-06-08 06:53:06 UTC) #14
keishi
On 2015/06/08 06:53:06, haraken wrote: > On 2015/06/08 06:42:24, keishi wrote: > > On 2015/06/08 ...
5 years, 6 months ago (2015-06-08 10:44:20 UTC) #15
haraken
LGTM https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.cpp File Source/core/dom/AXObjectCache.cpp (right): https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.cpp#newcode66 Source/core/dom/AXObjectCache.cpp:66: m_cache = AXObjectCache::create(*m_document); A slightly better way would ...
5 years, 6 months ago (2015-06-08 11:03:13 UTC) #16
dmazzoni
lgtm with just one concern about a suggested change. https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.cpp File Source/core/dom/AXObjectCache.cpp (right): https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.cpp#newcode77 Source/core/dom/AXObjectCache.cpp:77: ...
5 years, 6 months ago (2015-06-08 15:04:06 UTC) #18
haraken
https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.cpp File Source/core/dom/AXObjectCache.cpp (right): https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.cpp#newcode77 Source/core/dom/AXObjectCache.cpp:77: if (m_cache) On 2015/06/08 15:04:06, dmazzoni wrote: > On ...
5 years, 6 months ago (2015-06-08 23:38:15 UTC) #19
keishi
+tkent , could you review the change to public/web/WebAXObject.h ? Thanks.
5 years, 6 months ago (2015-06-22 02:00:39 UTC) #21
tkent
https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.h File Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.h#newcode148 Source/core/dom/AXObjectCache.h:148: class CORE_EXPORT ScopedAXObjectCache { Please explain the reason of ...
5 years, 6 months ago (2015-06-22 03:14:47 UTC) #22
tkent
> WebPrivatePtr.h: > > // Note: you must call reset(0) on the implementation side in ...
5 years, 6 months ago (2015-06-22 03:15:10 UTC) #23
keishi
https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.h File Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1081673003/diff/240001/Source/core/dom/AXObjectCache.h#newcode148 Source/core/dom/AXObjectCache.h:148: class CORE_EXPORT ScopedAXObjectCache { On 2015/06/22 03:14:47, tkent wrote: ...
5 years, 6 months ago (2015-06-22 05:23:56 UTC) #24
tkent
lgtm
5 years, 6 months ago (2015-06-22 05:32:50 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081673003/260001
5 years, 6 months ago (2015-06-22 08:14:21 UTC) #28
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 09:32:50 UTC) #29
Message was sent while issue was closed.
Committed patchset #13 (id:260001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197561

Powered by Google App Engine
This is Rietveld 408576698