[Files.app] Remove OK and Cancel buttons in task picker dialog

chrome/browser/resources/file_manager/foreground/js/default_action_dialog.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 
 /**
  * DefaultActionDialog contains a message, a list box, an ok button, and a
  * cancel button.
@@ skipping 75 matching lines @@
     return result;
   };
 
   /**
    * Shows dialog.
    *
    * @param {string} title Title in dialog caption.
    * @param {string} message Message in dialog caption.
    * @param {Array.<Object>} items Items to render in the list.
    * @param {number} defaultIndex Item to select by default.
-   * @param {function(Object=)} opt_onOk OK callback with the selected item.
-   * @param {function()=} opt_onCancel Cancel callback.
+   * @param {function(Object=)} onSelected Callback with the selected item.

[hirono, 2013/12/09 06:30:16]

An argument of the callback function seems not to be optional.

[yoshiki, 2013/12/12 13:22:25]

Done.

+   * @param {function()=} opt_onCancel Cancel callback with no selected item.
    */
   DefaultActionDialog.prototype.show = function(title, message, items,

[hirono, 2013/12/09 06:30:16]

Could you move the file into the js/ui directory?

[yoshiki, 2013/12/12 13:22:25]

I think so, but there are some other files which should be re-organized. Let's
do it in a separate patch.

-      defaultIndex, opt_onOk, opt_onCancel) {
+      defaultIndex, onSelectedItem, opt_onCancel) {
 
-    var show = FileManagerDialogBase.prototype.showOkCancelDialog.call(
-        this, title, message, opt_onOk, opt_onCancel);
+    this.onSelectedItemCallback_ = onSelectedItem;
+    this.onCancelledCallback_ = opt_onCancel || function() {};
+
+    var show = FileManagerDialogBase.prototype.showTitleAndTextDialog.call(
+        this, title, message);
 
     if (!show) {
       console.error('DefaultActionDialog can\'t be shown.');
       return;
     }
 
     if (!message) {
       this.text_.setAttribute('hidden', 'hidden');
     } else {
       this.text_.removeAttribute('hidden');
     }
 
     this.list_.startBatchUpdates();
     this.dataModel_.splice(0, this.dataModel_.length);
     for (var i = 0; i < items.length; i++) {
       this.dataModel_.push(items[i]);
     }
     this.selectionModel_.selectedIndex = defaultIndex;
     this.list_.endBatchUpdates();
   };
 
   /**
    * List activation handler. Closes dialog and calls 'ok' callback.
    * @param {number} index Activated index.
    */
   DefaultActionDialog.prototype.activateItemAtIndex_ = function(index) {
     this.hide();
-    this.onOk_(this.dataModel_.item(index));
+    this.onSelectedItemCallback_(this.dataModel_.item(index));
   };
 
   /**
    * Closes dialog and invokes callback with currently-selected item.
    * @override

[hirono, 2013/12/09 06:30:16]

This is no longer override method.

[yoshiki, 2013/12/12 13:22:25]

Done.

    */
-  DefaultActionDialog.prototype.onOkClick_ = function() {
+  DefaultActionDialog.prototype.onSelected_ = function() {
     this.activateItemAtIndex_(this.selectionModel_.selectedIndex);
   };
 
   /**
    * @override
    */
   DefaultActionDialog.prototype.onContainerKeyDown_ = function(event) {
     // Handle Escape.
     if (event.keyCode == 27) {
-      this.onCancelClick_(event);
+    this.hide();
       event.preventDefault();
     } else if (event.keyCode == 32 || event.keyCode == 13) {
-      this.onOkClick_();
+      this.onSelected_();

[hirono, 2013/12/09 06:30:16]

According to the comments of crbug.com/222941, clicking an item should close the
dialog and run the application. But the double click or enter key is needed to
do in the current implementation.

[yoshiki, 2013/12/12 13:22:25]

Done.

       event.preventDefault();
     }
   };
 
   return {DefaultActionDialog: DefaultActionDialog};
 });