Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 108163004: [CSS Blending] Implement the isolation property for SVG. (Closed)

Created:
7 years ago by mitica
Modified:
7 years ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

[CSS Blending] Implement the isolation property for SVG. This patch adds the isolation functionality to SVG, performs some cleanup on the current blend modes SVG implementation and adds tests to validate the feature. BUG=229615 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164028

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressing review comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -14 lines) Patch
A LayoutTests/css3/compositing/svg-isolation-default.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-isolation-default-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-isolation-isolated-group.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-isolation-isolated-group-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-isolation-simple.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-isolation-simple-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 2 1 chunk +11 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mitica
Hi, can you please review this change? Thanks!
7 years ago (2013-12-06 14:51:25 UTC) #1
Stephen Chennney
Some oddities to explain. :-) https://codereview.chromium.org/108163004/diff/1/Source/core/rendering/svg/SVGRenderingContext.cpp File Source/core/rendering/svg/SVGRenderingContext.cpp (right): https://codereview.chromium.org/108163004/diff/1/Source/core/rendering/svg/SVGRenderingContext.cpp#newcode117 Source/core/rendering/svg/SVGRenderingContext.cpp:117: bool hasBlendMode = style->hasBlendMode() ...
7 years ago (2013-12-06 16:15:11 UTC) #2
mitica
I've addressed my |friday code| patch, can you please have another look? Thanks! https://codereview.chromium.org/108163004/diff/1/Source/core/rendering/svg/SVGRenderingContext.cpp File ...
7 years ago (2013-12-09 09:04:30 UTC) #3
mitica
Hi Stephen, Could you please have another look at this? Thanks
7 years ago (2013-12-12 14:23:15 UTC) #4
Stephen Chennney
lgtm
7 years ago (2013-12-17 14:22:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitica@adobe.com/108163004/20001
7 years ago (2013-12-17 14:22:41 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/style/RenderStyle.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-17 14:22:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitica@adobe.com/108163004/40001
7 years ago (2013-12-17 17:35:12 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-17 18:40:46 UTC) #9
Message was sent while issue was closed.
Change committed as 164028

Powered by Google App Engine
This is Rietveld 408576698