gdata: Make GDataFileSystem::ReadDirectoryByPath() much more efficient

chrome/browser/chromeos/gdata/gdata_file_system_proxy.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_PROXY_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_PROXY_H_
 
 #include "chrome/browser/chromeos/gdata/gdata_errorcode.h"
+#include "chrome/browser/chromeos/gdata/gdata_file_system_interface.h"
 #include "webkit/chromeos/fileapi/remote_file_system_proxy.h"
 
 class Profile;
 
 namespace fileapi {
 class FileSystemURL;
 }
 
 namespace gdata {
 
 class GDataEntry;
 class GDataEntryProto;
-class GDataDirectoryProto;
 class GDataFileSystemInterface;
 
 // The interface class for remote file system proxy.
 class GDataFileSystemProxy : public fileapi::RemoteFileSystemProxyInterface {
  public:
   // |profile| is used to create GDataFileSystem, which is a per-profile
   // instance.
   explicit GDataFileSystemProxy(GDataFileSystemInterface* file_system);
 
   // fileapi::RemoteFileSystemProxyInterface overrides.
@@ skipping 83 matching lines @@
       GDataFileError error,
       scoped_ptr<GDataEntryProto> entry_proto);
 
   // Helper callback for relaying reply for ReadDirectory() to the calling
   // thread.
   void OnReadDirectory(
       const fileapi::FileSystemOperationInterface::ReadDirectoryCallback&
           callback,
       GDataFileError error,
       bool hide_hosted_documents,
-      scoped_ptr<GDataDirectoryProto> directory_proto);
+      scoped_ptr<gdata::GDataEntryProtoVector> proto_entries);

[achuithb, 2012/07/21 22:34:19]

nit: Don't think you need gdata::

[satorux1, 2012/07/21 23:23:36]

There are many places gdata:: prefix is used in this and the .cc file. I'll
revemo them in a separate patch.
http://code.google.com/p/chromium/issues/detail?id=138418

 
   // Helper callback for relaying reply for CreateWritableSnapshotFile() to
   // the calling thread.
   void OnCreateWritableSnapshotFile(
       const FilePath& virtual_path,
       const fileapi::WritableSnapshotFile& callback,
       GDataFileError result,
       const FilePath& local_path);
 
   // Helper callback for closing the local cache file and committing the dirty
@@ skipping 49 matching lines @@
   // GDataFileSystemProxy is owned by Profile, which outlives
   // GDataFileSystemProxy, which is owned by CrosMountPointProvider (i.e. by
   // the time Profile is removed, the file manager is already gone). Hence
   // it's safe to use this as a raw pointer.
   GDataFileSystemInterface* file_system_;
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_PROXY_H_