base/test/launcher: don't trim leading whitespace from test output

base/strings/string_split.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_split.h"
 
 #include "base/logging.h"
 #include "base/strings/string_util.h"
-#include "base/strings/utf_string_conversions.h"
 #include "base/third_party/icu/icu_utf.h"
 
 namespace base {
 
 namespace {
 
 template <typename STR>
 void SplitStringT(const STR& str,
                   const typename STR::value_type s,
                   bool trim_whitespace,
@@ skipping 166 matching lines @@
 void SplitStringDontTrim(const string16& str,
                          char16 c,
                          std::vector<string16>* r) {
   DCHECK(CBU16_IS_SINGLE(c));
   SplitStringT(str, c, false, r);
 }
 
 void SplitStringDontTrim(const std::string& str,
                          char c,
                          std::vector<std::string>* r) {
-  DCHECK(IsStringUTF8(str));

[Nico, 2015/04/16 17:05:24]

This change looks both unrelated and incorrect. (`c` is a single byte, so
this'll only work for utf-8)

[ncarter (slow), 2015/04/16 18:08:00]

"only work for UTF-8" as opposed to what?

Did you see my message where I explained that it's both related and correct?
Here's what I wrote:

===

I've removed the IsUTF8 check here after determining it to be unnecessary.
Whether it's extended ascii or UTF-8, we can strip whitespace and split along
newlines all the same. SplitString and SplitStringDontTrim share an
implementation, so what's valid input for the former should be valid for the
latter.

At least test on the linux asan bot generates stdio which is not valid UTF-8,
though I don't know why this is.

Archaeological research shows this DCHECK to have been introduced during a
file-move of this function, as part of https://codereview.chromium.org/3366011 .

===

[ncarter (slow), 2015/04/16 18:08:50]

And oh, to understand the relationship: see the failed tryjob on patchset 1.

 #if CHAR_MIN < 0
   DCHECK_GE(c, 0);
 #endif
   DCHECK_LT(c, 0x7F);
   SplitStringT(str, c, false, r);
 }
 
 void SplitStringAlongWhitespace(const string16& str,
                                 std::vector<string16>* result) {
   SplitStringAlongWhitespaceT(str, result);
 }
 
 void SplitStringAlongWhitespace(const std::string& str,
                                 std::vector<std::string>* result) {
   SplitStringAlongWhitespaceT(str, result);
 }
 
 }  // namespace base