Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: gpu/command_buffer/service/gpu_tracer.h

Issue 1081483002: GPU Tracer no longer issue device traces when device category is off. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit test to test that trace calls are only called when categories are enabled Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gpu_tracer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gpu_tracer.h
diff --git a/gpu/command_buffer/service/gpu_tracer.h b/gpu/command_buffer/service/gpu_tracer.h
index 3f8ec84812f496717f94c563f64ffeb6ef3dc4eb..1bd19730223467756aa952c629817418bebbc03b 100644
--- a/gpu/command_buffer/service/gpu_tracer.h
+++ b/gpu/command_buffer/service/gpu_tracer.h
@@ -156,14 +156,16 @@ class GPU_EXPORT GPUTrace
gfx::GPUTimingClient* gpu_timing_client,
const std::string& category,
const std::string& name,
- const bool enabled);
+ const bool tracing_service,
+ const bool tracing_device);
void Destroy(bool have_context);
- void Start(bool trace_service);
- void End(bool tracing_service);
+ void Start();
+ void End();
bool IsAvailable();
- bool IsEnabled() { return enabled_; }
+ bool IsServiceTraceEnabled() const { return service_enabled_; }
+ bool IsDeviceTraceEnabled() const { return device_enabled_; }
void Process();
private:
@@ -177,7 +179,8 @@ class GPU_EXPORT GPUTrace
std::string name_;
scoped_refptr<Outputter> outputter_;
scoped_ptr<gfx::GPUTimer> gpu_timer_;
- const bool enabled_ = false;
+ const bool service_enabled_ = false;
+ const bool device_enabled_ = false;
DISALLOW_COPY_AND_ASSIGN(GPUTrace);
};
« no previous file with comments | « no previous file | gpu/command_buffer/service/gpu_tracer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698