GPU Tracer no longer issue device traces when device category is off.

GPU Tracer no longer issue device traces when device category is off.

R=vmiura@chromium.org
BUG=None

Committed: https://crrev.com/052dacb5389b998417a272983e0db6912ef54c4f
Cr-Commit-Position: refs/heads/master@{#324736}

[vmiura, 2015-04-10 22:18:50]

https://codereview.chromium.org/1081483002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gpu_tracer.cc (right):

https://codereview.chromium.org/1081483002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gpu_tracer.cc:93: if (enabled &&
Thinking about this, "enabled" here and "tracing_service" in Start() and End()
seem rather inconsistent.

Should we have both 'device_enabled' and 'service_enabled' in the constructor?

[David Yen, 2015-04-10 22:36:10]

https://codereview.chromium.org/1081483002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gpu_tracer.cc (right):

https://codereview.chromium.org/1081483002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gpu_tracer.cc:93: if (enabled &&
On 2015/04/10 22:18:50, vmiura wrote:
> Thinking about this, "enabled" here and "tracing_service" in Start() and End()
> seem rather inconsistent.
> 
> Should we have both 'device_enabled' and 'service_enabled' in the constructor?

Done.

[vmiura, 2015-04-10 22:50:50]

LGTM

[David Yen, 2015-04-10 22:55:20]

On 2015/04/10 22:50:50, vmiura wrote:
> LGTM

Sorry, I added unit tests to test that the GL calls and outputter calls are only
called when the right categories are enabled. PTAL.

[David Yen, 2015-04-10 22:55:21]

On 2015/04/10 22:50:50, vmiura wrote:
> LGTM

Sorry, I added unit tests to test that the GL calls and outputter calls are only
called when the right categories are enabled. PTAL.

[vmiura, 2015-04-10 23:56:52]

The CQ bit was checked by vmiura@chromium.org

[vmiura, 2015-04-10 23:56:53]

The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org
Link to the patchset: https://codereview.chromium.org/1081483002/#ps40001
(title: "Added unit test to test that trace calls are only called when
categories are enabled")

[commit-bot: I haz the power, 2015-04-10 23:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1081483002/40001

[commit-bot: I haz the power, 2015-04-11 01:09:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-11 01:10:49]

Patchset 3 (id:??) landed as
https://crrev.com/052dacb5389b998417a272983e0db6912ef54c4f
Cr-Commit-Position: refs/heads/master@{#324736}