Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1081483002: GPU Tracer no longer issue device traces when device category is off. (Closed)

Created:
5 years, 8 months ago by David Yen
Modified:
5 years, 8 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org, sunnyps
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GPU Tracer no longer issue device traces when device category is off. R=vmiura@chromium.org BUG=None Committed: https://crrev.com/052dacb5389b998417a272983e0db6912ef54c4f Cr-Commit-Position: refs/heads/master@{#324736}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Set gpu trace category enabling at constructor for both device/service #

Patch Set 3 : Added unit test to test that trace calls are only called when categories are enabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -31 lines) Patch
M gpu/command_buffer/service/gpu_tracer.h View 1 2 chunks +8 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 1 8 chunks +17 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 1 2 4 chunks +45 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
David Yen
5 years, 8 months ago (2015-04-10 20:59:52 UTC) #1
vmiura
https://codereview.chromium.org/1081483002/diff/1/gpu/command_buffer/service/gpu_tracer.cc File gpu/command_buffer/service/gpu_tracer.cc (right): https://codereview.chromium.org/1081483002/diff/1/gpu/command_buffer/service/gpu_tracer.cc#newcode93 gpu/command_buffer/service/gpu_tracer.cc:93: if (enabled && Thinking about this, "enabled" here and ...
5 years, 8 months ago (2015-04-10 22:18:50 UTC) #2
David Yen
https://codereview.chromium.org/1081483002/diff/1/gpu/command_buffer/service/gpu_tracer.cc File gpu/command_buffer/service/gpu_tracer.cc (right): https://codereview.chromium.org/1081483002/diff/1/gpu/command_buffer/service/gpu_tracer.cc#newcode93 gpu/command_buffer/service/gpu_tracer.cc:93: if (enabled && On 2015/04/10 22:18:50, vmiura wrote: > ...
5 years, 8 months ago (2015-04-10 22:36:10 UTC) #3
vmiura
LGTM
5 years, 8 months ago (2015-04-10 22:50:50 UTC) #4
David Yen
On 2015/04/10 22:50:50, vmiura wrote: > LGTM Sorry, I added unit tests to test that ...
5 years, 8 months ago (2015-04-10 22:55:20 UTC) #5
David Yen
On 2015/04/10 22:50:50, vmiura wrote: > LGTM Sorry, I added unit tests to test that ...
5 years, 8 months ago (2015-04-10 22:55:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081483002/40001
5 years, 8 months ago (2015-04-10 23:59:45 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-11 01:09:16 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-11 01:10:49 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/052dacb5389b998417a272983e0db6912ef54c4f
Cr-Commit-Position: refs/heads/master@{#324736}

Powered by Google App Engine
This is Rietveld 408576698