Issue 1081443005: Make the C++ PlatformViewportAndroid's dtor call the Java PVA's destroy() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1081443005: Make the C++ PlatformViewportAndroid's dtor call the Java PVA's destroy() method. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make the C++ PlatformViewportAndroid's dtor call the Java PVA's detach() method. In particular, after destruction of the C++ PVA, the Java PVA will no longer try to call into it. (Rename the previously-unused destroy() to detach(), and make it not call into native code.) BUG=Fixes #95 R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dc865d4ac61ebec665f91988d8247c1fde26bbc4

Patch Set 1 #

Patch Set 2 : use a weak ref instead #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -12 lines)			Patch
M	services/native_viewport/android/src/org/chromium/mojo/PlatformViewportAndroid.java	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
M	services/native_viewport/platform_viewport_android.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	services/native_viewport/platform_viewport_android.cc	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

I'm just a monkey following orders of the Cargo Cult.

5 years, 8 months ago (2015-04-15 20:33:38 UTC) #1

viettrungluu

5 years, 8 months ago (2015-04-15 22:15:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
dc865d4ac61ebec665f91988d8247c1fde26bbc4 (presubmit successful).

Expand Messages | Collapse Messages