Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1081443002: Revert of Make full GC reduce memory footprint an explicit event in the idle notification handler. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make full GC reduce memory footprint an explicit event in the idle notification handler. (patchset #2 id:20001 of https://codereview.chromium.org/1072363002/) Reason for revert: [Sheriff] breaks nosnap with timeouts: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/2513 http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6220 Original issue's description: > Make full GC reduce memory footprint an explicit event in the idle notification handler. > > BUG= > > Committed: https://crrev.com/845705aa99b6bfa8d264cfda1c3b5f1229802ab5 > Cr-Commit-Position: refs/heads/master@{#27753} TBR=ulan@chromium.org,rmcilroy@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7898475e92e2be05868a5755815732bd11f6a3ca Cr-Commit-Position: refs/heads/master@{#27755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -58 lines) Patch
M src/heap/gc-idle-time-handler.h View 4 chunks +0 lines, -15 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 4 chunks +8 lines, -21 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Make full GC reduce memory footprint an explicit event in the idle ...
5 years, 8 months ago (2015-04-10 18:21:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081443002/1
5 years, 8 months ago (2015-04-10 18:21:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 18:21:51 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 18:21:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7898475e92e2be05868a5755815732bd11f6a3ca
Cr-Commit-Position: refs/heads/master@{#27755}

Powered by Google App Engine
This is Rietveld 408576698