Source/core/layout/LayoutGrid.cpp - Issue 1081433005: LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutGrid.cpp

Issue 1081433005: LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: remove flexbox change Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutGrid.cpp

diff --git a/Source/core/layout/LayoutGrid.cpp b/Source/core/layout/LayoutGrid.cpp

index 2de38a480b67dc7c3a5bede6d2eb962a899aec5a..8f0224d68275a6e7a568fd4e3a9049e8ded71b0b 100644

--- a/Source/core/layout/LayoutGrid.cpp

+++ b/Source/core/layout/LayoutGrid.cpp

@@ -581,7 +581,7 @@ double LayoutGrid::computeNormalizedFractionBreadth(Vector<GridTrack>& tracks, c

bool LayoutGrid::hasDefiniteLogicalSize(GridTrackSizingDirection direction) const

{

- return (direction == ForRows) ? hasDefiniteLogicalHeight() : hasDefiniteLogicalWidth();

+ return (direction == ForRows) ? logicalHeightIsDefinite(style()->logicalHeight()) : hasDefiniteLogicalWidth();

}

GridTrackSize LayoutGrid::gridTrackSize(GridTrackSizingDirection direction, size_t i) const

« Source/core/layout/LayoutBox.cpp ('K') | « Source/core/layout/LayoutBox.cpp ('k') | no next file » | no next file with comments »