Chromium Code Reviews Chromium Code Reviews
Issue 1081433005:
LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/css3/flexbox/percentage-height-in-abspos-expected.html |
| diff --git a/LayoutTests/css3/flexbox/percentage-height-in-abspos-expected.html b/LayoutTests/css3/flexbox/percentage-height-in-abspos-expected.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..e96320e2d01b8496f407371c72f36b0c8e3138f3 |
| --- /dev/null |
| +++ b/LayoutTests/css3/flexbox/percentage-height-in-abspos-expected.html |
| @@ -0,0 +1,45 @@ |
| +<!DOCTYPE html> |
| +<style> |
| +body { |
| + position: relative; |
| + width: 800px; |
| + height: 600px; |
| +} |
| + |
| +div { |
| + background-color: grey; |
|
Manuel Rego
2015/04/24 05:55:17
Again this doesn't seem needed.
|
| +} |
| + |
| +#container { |
| + background-color: red; |
|
Manuel Rego
2015/04/24 05:55:17
Nit: in the -expected file this is not needed as y
|
| + position: absolute; |
| + top: 0; |
| + bottom: 0; |
| + left: 0; |
| + right: 0; |
| + display: flex; |
| + flex-direction: column; |
|
Manuel Rego
2015/04/24 05:55:17
Nit: we don't need a flexbox here
|
| +} |
| + |
| +#top-bar { |
| + background-color: green; |
| + height: 100px; |
| +} |
| + |
| +#content { |
| + background-color: blue; |
| + height: 500px; |
| +} |
| +</style> |
| + |
| + |
| +<div id="container"> |
| + <div id="top-bar"> |
| + Tests that percentage heights get resolved correctly when the flexbox is |
| + </div> |
| + <div id="content"> |
| + absolutely positioned without an explicit height. |
| + </div> |
| +</div> |
| + |
| + |
