LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite

Source/core/layout/LayoutBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 4247 matching lines @@
         return logicalWidthIsResolvable(*box->containingBlock());
 
     return false;
 }
 
 bool LayoutBox::hasDefiniteLogicalWidth() const
 {
     return logicalWidthIsResolvable(*this);
 }
 
-bool LayoutBox::percentageLogicalHeightIsResolvable() const
+bool LayoutBox::logicalHeightIsDefinite(const Length& length) const
 {
-    Length fakeLength(100, Percent);
-    return computePercentageLogicalHeight(fakeLength) != -1;
-}
+    if (length.isIntrinsicOrAuto())

[Manuel Rego, 2015/09/23 10:22:02]

I think this still has the original problem.

If the grid is abspos and has "height: auto;"
it'll identified as indefinite.
However, if top and bottom are non-auto
the height would be definite.

[cbiesinger, 2015/10/02 16:16:43]

I don't believe that's a correct interpretation of the CSS spec. At least,
https://drafts.csswg.org/css-sizing-3/#definite does not indicate that this
would be a definite size?

+        return false;
+    if (length.isFixed())
+        return true;
+    if (length.hasPercent()) {
+        if (hasOverrideContainingBlockLogicalHeight())
+            return overrideContainingBlockContentLogicalHeight() != -1;
 
-bool LayoutBox::hasDefiniteLogicalHeight() const
-{
-    const Length& logicalHeight = style()->logicalHeight();
-    if (logicalHeight.isIntrinsicOrAuto())
-        return false;
-    if (logicalHeight.isFixed())
+        return computePercentageLogicalHeight(length) != -1;
+    }
+    if (length.isMaxSizeNone())

[Manuel Rego, 2015/09/23 10:22:02]

I don't get what the max-height has to do in order
to check if it's definite or not.
Specially if "max-height: none;" implies
that the size is definite.

         return true;
-    // The size of the containing block of an absolutely positioned element is always definite with respect to that
-    // element (http://dev.w3.org/csswg/css-sizing-3/#definite).
-    if (isOutOfFlowPositioned())
-        return true;
-    if (hasOverrideContainingBlockLogicalHeight())
-        return overrideContainingBlockContentLogicalHeight() != -1;
-
-    return percentageLogicalHeightIsResolvable();
+    return false;
 }
 
 bool LayoutBox::hasUnsplittableScrollingOverflow() const
 {
     // We will paginate as long as we don't scroll overflow in the pagination direction.
     bool isHorizontal = isHorizontalWritingMode();
     if ((isHorizontal && !scrollsOverflowY()) || (!isHorizontal && !scrollsOverflowX()))
         return false;
 
     // We do have overflow. We'll still be willing to paginate as long as the block
     // has auto logical height, auto or undefined max-logical-height and a zero or auto min-logical-height.
     // Note this is just a heuristic, and it's still possible to have overflow under these
     // conditions, but it should work out to be good enough for common cases. Paginating overflow
     // with scrollbars present is not the end of the world and is what we used to do in the old model anyway.
     return !style()->logicalHeight().isIntrinsicOrAuto()
-        || (!style()->logicalMaxHeight().isIntrinsicOrAuto() && !style()->logicalMaxHeight().isMaxSizeNone() && (!style()->logicalMaxHeight().hasPercent() || percentageLogicalHeightIsResolvable()))
-        || (!style()->logicalMinHeight().isIntrinsicOrAuto() && style()->logicalMinHeight().isPositive() && (!style()->logicalMinHeight().hasPercent() || percentageLogicalHeightIsResolvable()));
+        || (logicalHeightIsDefinite(style()->logicalMaxHeight()) && !style()->logicalMaxHeight().isMaxSizeNone())
+        || (logicalHeightIsDefinite(style()->logicalMinHeight()) && style()->logicalMinHeight().isPositive());
 }
 
 bool LayoutBox::isUnsplittableForPagination() const
 {
     return isReplaced() || hasUnsplittableScrollingOverflow() || (parent() && isWritingModeRoot());
 }
 
 LayoutUnit LayoutBox::lineHeight(bool /*firstLine*/, LineDirectionMode direction, LinePositionMode /*linePositionMode*/) const
 {
     if (isReplaced())
@@ skipping 423 matching lines @@
     StyleImage* borderImage = style()->borderImage().image();
     return borderImage && borderImage->canRender(*this, style()->effectiveZoom()) && borderImage->isLoaded();
 }
 
 ShapeOutsideInfo* LayoutBox::shapeOutsideInfo() const
 {
     return ShapeOutsideInfo::isEnabledFor(*this) ? ShapeOutsideInfo::info(*this) : nullptr;
 }
 
 } // namespace blink