LayoutTests/css3/flexbox/percentage-height-in-abspos.html - Issue 1081433005: LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/flexbox/percentage-height-in-abspos.html

Issue 1081433005: LayoutBox::hasDefiniteLogicalHeight() should not consider abspos boxes as definite (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/percentage-height-in-abspos-expected.html » ('j') | LayoutTests/css3/flexbox/percentage-height-in-abspos-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 body {

	4 position: relative;

	5 width: 800px;

	6 height: 600px;

	7 }

	8

	9 div {

	10 background-color: grey;
	Manuel Rego 2015/04/24 05:55:17 Don't get what you need this. Don't get what you need this.
	11 }

	12

	13 #container {

	14 background-color: red;

	15 position: absolute;

	16 top: 0;

	17 bottom: 0;

	18 left: 0;

	19 right: 0;

	20 display: flex;

	21 flex-direction: column;

	22 }

	23

	24 #top-bar {

	25 background-color: green;

	26 height: 20%;

	27 }

	28

	29 #content {

	30 background-color: blue;

	31 flex-basis: 100%;

	32 }

	33 </style>

	34

	35

	36 <div id="container">

	37 <div id="top-bar">

	38 Tests that percentage heights get resolved correctly when the flexbox is
	Manuel Rego 2015/04/24 05:55:17 Nit: this is a common description for a check-layo Nit: this is a common description for a check-layout.js test. However for ref-tests the description usually explains how to visually check if the test passes or not. Things like you shouldn't see any red, etc.
	39 </div>

	40 <div id="content">

	41 absolutely positioned without an explicit height.

	42 </div>

	43 </div>

	44

	45

OLD	NEW