Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 1081413004: [content] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in left out content/ BUG=466848 Committed: https://crrev.com/c2a1922419f12248bf72a1ea744e66ced39b4cd5 Cr-Commit-Position: refs/heads/master@{#325972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/histogram_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/theme_helper_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-20 14:27:15 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 8 months ago (2015-04-20 16:35:43 UTC) #3
jsbell
lgtm
5 years, 8 months ago (2015-04-20 16:36:49 UTC) #5
anujsharma
On 2015/04/20 16:36:49, jsbell wrote: > lgtm Thanks Avi and jsbell for lgtm.
5 years, 8 months ago (2015-04-21 02:11:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081413004/1
5 years, 8 months ago (2015-04-21 02:12:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 02:59:40 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 03:00:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2a1922419f12248bf72a1ea744e66ced39b4cd5
Cr-Commit-Position: refs/heads/master@{#325972}

Powered by Google App Engine
This is Rietveld 408576698