Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1081413003: [Sync] Have configuration specify which datatypes are ready to sync (Closed)

Created:
5 years, 8 months ago by Nicolas Zea
Modified:
5 years, 8 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Have configuration specify which datatypes are ready to sync In preparation for performing model association while other types are downloading, the BackendDataTypeConfigurer::ConfigureDataTypes method will now return those types that are ready to sync without further intervention from sync. These are the types that were already syncing previously, and therefore don't need to be downloaded or purged. A followup patch will add the association logic and tests. BUG=477063 Committed: https://crrev.com/92b21f8adf73d5198e05178b3bdc2ee5234c731f Cr-Commit-Position: refs/heads/master@{#325582}

Patch Set 1 #

Patch Set 2 : Add tests" #

Patch Set 3 : Self review #

Patch Set 4 : Fix components_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -92 lines) Patch
M chrome/browser/sync/glue/sync_backend_host.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 2 17 chunks +100 lines, -78 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M components/sync_driver/backend_data_type_configurer.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M components/sync_driver/data_type_manager_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nicolas Zea
+Pavel, PTAL
5 years, 8 months ago (2015-04-16 20:50:50 UTC) #2
pavely
lgtm
5 years, 8 months ago (2015-04-16 23:46:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081413003/60001
5 years, 8 months ago (2015-04-16 23:50:45 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-17 02:00:23 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 02:01:22 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/92b21f8adf73d5198e05178b3bdc2ee5234c731f
Cr-Commit-Position: refs/heads/master@{#325582}

Powered by Google App Engine
This is Rietveld 408576698