Refactor safe-browsing build-config definitions

chrome/chrome_tests.gypi

Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 0657d6fb309ce9aaa0593413472898a73363f12c..cad2411926dfd1852e3c8c0a1793048d35806773 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -2197,11 +2197,9 @@
         ['enable_web_speech==1', {
           'sources': [ '<@(chrome_browser_tests_speech_sources)' ],
         }],
-        ['safe_browsing==1', {
+        # TODO(sgurun) enable tests for safe_browsing==2.

[Scott Hess - ex-Googler, 2015/04/16 19:34:22]

I see that the OLD version is different than it is for my stale CL, there are no
longer cases for 0 and 2..  I wonder if this change still makes sense?

[Nathan Parker, 2015/04/16 20:01:53]

I think it should be just sb==1.  Fixed.  The tests it runs are related to
database updates, etc.

I'll leave the todo since we need some tests for mode 2, but not precisely
these.

[Scott Hess - ex-Googler, 2015/04/17 15:01:40]

Acknowledged.

+        ['safe_browsing==1 or safe_browsing==2', {
           'sources': [ '<@(chrome_browser_tests_full_safe_browsing_sources)' ],
-          'defines': [
-            'FULL_SAFE_BROWSING',
-          ],
         }],
         ['enable_captive_portal_detection==1', {
           'sources': [ 'browser/captive_portal/captive_portal_browsertest.cc' ],