chrome/renderer/BUILD.gn - Issue 1081403002: Refactor safe-browsing build-config definitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/BUILD.gn

Issue 1081403002: Refactor safe-browsing build-config definitions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again to fix collision Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/BUILD.gn

diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn

index 312a879d9eca3c01df5b6eac76d342a63bab8a5f..2fe4a66cc44399616174e562b7f943e57173394c 100644

--- a/chrome/renderer/BUILD.gn

+++ b/chrome/renderer/BUILD.gn

@@ -86,26 +86,20 @@ static_library("renderer") {

]

}

- if (safe_browsing_mode == 1) {

- sources += rebase_path(gypi_values.chrome_renderer_safe_browsing_sources,

+ if (safe_browsing_mode != 0) {

+ sources += rebase_path(gypi_values.chrome_renderer_basic_safe_browsing_sources,

".",

"..")

- sources +=

- rebase_path(gypi_values.chrome_renderer_basic_safe_browsing_sources,

- ".",

- "..")

- defines += [ "FULL_SAFE_BROWSING" ]

- deps += [

- "//chrome/common/safe_browsing:proto",

- "//third_party/smhasher:murmurhash3",

- ]

- }

- if (safe_browsing_mode == 2) {

- sources +=

- rebase_path(gypi_values.chrome_renderer_basic_safe_browsing_sources,

- ".",

- "..")

- defines += [ "MOBILE_SAFE_BROWSING" ]

+ if (safe_browsing_mode == 1) {

+ sources +=

+ rebase_path(gypi_values.chrome_renderer_safe_browsing_sources,

+ ".",

+ "..")

+ deps += [

+ "//chrome/common/safe_browsing:proto",

+ "//third_party/smhasher:murmurhash3",

+ ]

+ }

}

if (enable_extensions) {

« no previous file with comments | « chrome/common/safe_browsing/safebrowsing_messages.h ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »