Refactor safe-browsing build-config definitions

build/common.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7b30cec785c020eae2bdd5f69ba2ce72a95403bf..5109597f4aaef62bff16605bdb2716db6af52284 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2977,6 +2977,25 @@
       ['v8_use_external_startup_data==1', {
        'defines': ['V8_USE_EXTERNAL_STARTUP_DATA'],
       }],
+
+      # SAFE_BROWSING_SERVICE - browser manages a safe-browsing service.
+      # SAFE_BROWSING_DB_LOCAL - service manages a local database.
+      # SAFE_BROWSING_DB_REMOTE - service talks via API to a database
+      # SAFE_BROWSING_CSD - enable client-side phishing detection.
+      ['safe_browsing==1', {
+        'defines': [
+          'FULL_SAFE_BROWSING',

[Lei Zhang (Do not use), 2015/04/17 18:04:48]

Are there still uses of these FULL_SAFE_BROWSING and MOBILE_SAFE_BROWSING
outside of this CL that you haven't gotten rid of?

+          'SAFE_BROWSING_CSD',
+          'SAFE_BROWSING_DB_LOCAL',
+          'SAFE_BROWSING_SERVICE',
+        ],
+      }],
+      ['safe_browsing==2', {
+        'defines': [
+          'MOBILE_SAFE_BROWSING',
+          'SAFE_BROWSING_SERVICE',
+        ],
+      }],
     ],  # conditions for 'target_defaults'
     'target_conditions': [
       ['<(use_libpci)==1', {