chrome/browser/task_manager/task_manager.h - Issue 1081323003: Convert renderer JS memory usage reporting to use Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager.h

Issue 1081323003: Convert renderer JS memory usage reporting to use Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utility-process-report-js-memory

Patch Set: Fix build files. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/process_resource_usage.cc ('K') | « chrome/browser/task_manager/resource_provider.h ('k') | chrome/browser/task_manager/task_manager.cc » ('j') | chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager.h

diff --git a/chrome/browser/task_manager/task_manager.h b/chrome/browser/task_manager/task_manager.h

index d383f455a242e07a30ee49142eba82b893494014..828246b69011d7a56218c86dd7f91a60993ee8b9 100644

--- a/chrome/browser/task_manager/task_manager.h

+++ b/chrome/browser/task_manager/task_manager.h

@@ -281,7 +281,7 @@ class TaskManagerModel : public base::RefCountedThreadSafe<TaskManagerModel> {

// changes to the model.

void ModelChanged();

- // Updates the values for all rows.

+ // Updates the values for all rows.

void Refresh();

void NotifyResourceTypeStats(

@@ -291,10 +291,6 @@ class TaskManagerModel : public base::RefCountedThreadSafe<TaskManagerModel> {

void NotifyVideoMemoryUsageStats(

const content::GPUVideoMemoryUsageStats& video_memory_usage_stats);

- void NotifyV8HeapStats(base::ProcessId renderer_id,

- size_t v8_memory_allocated,

- size_t v8_memory_used);

void NotifyBytesRead(const net::URLRequest& request, int bytes_read);

void RegisterOnDataReadyCallback(const base::Closure& callback);