chrome/browser/task_manager/resource_provider.h - Issue 1081323003: Convert renderer JS memory usage reporting to use Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/resource_provider.h

Issue 1081323003: Convert renderer JS memory usage reporting to use Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utility-process-report-js-memory

Patch Set: Rebase and fix tests. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/task_manager/resource_provider.h

diff --git a/chrome/browser/task_manager/resource_provider.h b/chrome/browser/task_manager/resource_provider.h

index 3b39c1be2538b093a33d2cbb9b87e3db0c722001..745f94b20331f1f269de50175567470d0ea190ce 100644

--- a/chrome/browser/task_manager/resource_provider.h

+++ b/chrome/browser/task_manager/resource_provider.h

@@ -96,8 +96,6 @@ class Resource {

virtual void NotifyResourceTypeStats(

const blink::WebCache::ResourceTypeStats& stats) {}

- virtual void NotifyV8HeapStats(size_t v8_memory_allocated,

- size_t v8_memory_used) {}

static const char* GetResourceTypeAsString(const Type type) {

switch (type) {

« no previous file with comments | « chrome/browser/task_manager/renderer_resource.cc ('k') | chrome/browser/task_manager/task_manager.h » ('j') | no next file with comments »