Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6153)

Unified Diff: chrome/browser/task_manager/renderer_resource.h

Issue 1081323003: Convert renderer JS memory usage reporting to use Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utility-process-report-js-memory
Patch Set: Rebase and fix tests. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/renderer_resource.h
diff --git a/chrome/browser/task_manager/renderer_resource.h b/chrome/browser/task_manager/renderer_resource.h
index 384c1593787a4b6722133fab6ce82e7621a249aa..6e3d6e930d2e2b84e9aa63736caf24b9a4381621 100644
--- a/chrome/browser/task_manager/renderer_resource.h
+++ b/chrome/browser/task_manager/renderer_resource.h
@@ -6,8 +6,11 @@
#define CHROME_BROWSER_TASK_MANAGER_RENDERER_RESOURCE_H_
#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
#include "chrome/browser/task_manager/resource_provider.h"
+class ProcessResourceUsage;
+
namespace content {
class RenderViewHost;
}
@@ -44,16 +47,12 @@ class RendererResource : public Resource {
void NotifyResourceTypeStats(
const blink::WebCache::ResourceTypeStats& stats) override;
- void NotifyV8HeapStats(size_t v8_memory_allocated,
- size_t v8_memory_used) override;
-
content::RenderViewHost* render_view_host() const {
return render_view_host_;
}
private:
base::ProcessHandle process_;
- int pid_;
int unique_process_id_;
// RenderViewHost we use to fetch stats.
@@ -64,10 +63,7 @@ class RendererResource : public Resource {
// This flag is true if we are waiting for the renderer to report its stats.
bool pending_stats_update_;
- // We do a similar dance to gather the V8 memory usage in a process.
- size_t v8_memory_allocated_;
- size_t v8_memory_used_;
- bool pending_v8_memory_allocated_update_;
+ scoped_ptr<ProcessResourceUsage> process_resource_usage_;
DISALLOW_COPY_AND_ASSIGN(RendererResource);
};
« no previous file with comments | « chrome/browser/task_manager/child_process_resource_provider.cc ('k') | chrome/browser/task_manager/renderer_resource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698