Improve precision of JS printer callbacks (2nd try)

pkg/compiler/lib/src/io/code_output.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.code_output;
 
 import 'dart:async';
 
 import 'source_information.dart';
 
-class CodeOutputMarker {
-  final int offsetDelta;
-  final SourceLocation sourcePosition;
-
-  CodeOutputMarker(this.offsetDelta, this.sourcePosition);
-}
-
 abstract class CodeOutputListener {
   void onText(String text);
   void onDone(int length);
 }
 
 abstract class CodeOutput {
   /// Write [text] to this output.
   ///
   /// If the output is closed, a [StateError] is thrown.
   void add(String text);
 
   /// Adds the content of [buffer] to the output and adds its markers to
   /// [markers].
   ///
   /// If the output is closed, a [StateError] is thrown.
   void addBuffer(CodeBuffer buffer);
 
   /// Returns the number of characters currently write to this output.
   int get length;
 
   /// Returns `true` if this output has been closed.
   bool get isClosed;
 
   /// Closes the output. Further writes will cause a [StateError].
   void close();
 
-  /// Sets the [sourcePosition] for the code next added to this output.
-  void setSourceLocation(SourceLocation sourcePosition);
+  /// Adds a [sourceLocation] at the specified [targetOffset] in the buffer.
+  void addSourceLocation(int targetOffset, SourceLocation sourcePosition);
 
   /// Applies [f] to every marker in this output.
   void forEachSourceLocation(void f(int targetOffset,
                                     SourceLocation sourceLocation));
 }
 
 abstract class AbstractCodeOutput extends CodeOutput {
-  List<CodeOutputMarker> markers = new List<CodeOutputMarker>();
-  int lastBufferOffset = 0;
-  int mappedRangeCounter = 0;
+  Map<int, List<SourceLocation>> markers = <int, List<SourceLocation>>{};
   bool isClosed = false;
 
   void _addInternal(String text);
 
   @override
   void add(String text) {
     if (isClosed) {
       throw new StateError("Code output is closed. Trying to write '$text'.");
     }
-    if (mappedRangeCounter == 0) setSourceLocation(null);
     _addInternal(text);
   }
 
   @override
   void addBuffer(CodeBuffer other) {
     if (other.markers.length > 0) {
-      CodeOutputMarker firstMarker = other.markers[0];
-      int offsetDelta =
-          length + firstMarker.offsetDelta - lastBufferOffset;
-      markers.add(new CodeOutputMarker(offsetDelta,
-                                       firstMarker.sourcePosition));
-      for (int i = 1; i < other.markers.length; ++i) {
-        markers.add(other.markers[i]);
-      }
-      lastBufferOffset = length + other.lastBufferOffset;
+      other.markers.forEach(
+          (int targetOffset, List<SourceLocation> sourceLocations) {
+        markers.putIfAbsent(length + targetOffset, () => <SourceLocation>[])
+            .addAll(sourceLocations);
+      });
     }
     if (!other.isClosed) {
       other.close();
     }
     _addInternal(other.getText());
   }
 
-  void beginMappedRange() {
-    ++mappedRangeCounter;
+  void addSourceLocation(int targetOffset,
+                         SourceLocation sourceLocation) {
+    assert(targetOffset <= length);
+    List<SourceLocation> sourceLocations =
+        markers.putIfAbsent(targetOffset, () => <SourceLocation>[]);
+    sourceLocations.add(sourceLocation);
   }
 
-  void endMappedRange() {
-    assert(mappedRangeCounter > 0);
-    --mappedRangeCounter;
-  }
-
-  void setSourceLocation(SourceLocation sourcePosition) {
-    if (sourcePosition == null) {
-      if (markers.length > 0 && markers.last.sourcePosition == null) return;
-    }
-    int offsetDelta = length - lastBufferOffset;
-    markers.add(new CodeOutputMarker(offsetDelta, sourcePosition));
-    lastBufferOffset = length;
-  }
-
-  void forEachSourceLocation(void f(int targetOffset, var sourcePosition)) {
-    int targetOffset = 0;
-    markers.forEach((marker) {
-      targetOffset += marker.offsetDelta;
-      f(targetOffset, marker.sourcePosition);
+  void forEachSourceLocation(void f(int targetOffset, var sourceLocation)) {
+    markers.forEach((int targetOffset, List<SourceLocation> sourceLocations) {
+      for (SourceLocation sourceLocation in sourceLocations) {
+        f(targetOffset, sourceLocation);
+      }
     });
   }
 
   void close() {
     if (isClosed) {
       throw new StateError("Code output is already closed.");
     }
     isClosed = true;
   }
 }
@@ skipping 37 matching lines @@
   }
 
   void close() {
     output.close();
     super.close();
     if (_listeners != null) {
       _listeners.forEach((listener) => listener.onDone(length));
     }
   }
 }