Drive: Add response handling to BatchUploadRequst class.

google_apis/drive/drive_api_requests.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GOOGLE_APIS_DRIVE_DRIVE_API_REQUESTS_H_
 #define GOOGLE_APIS_DRIVE_DRIVE_API_REQUESTS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 48 matching lines @@
 
  private:
   Visibility visibility_;
   std::string key_;
   std::string value_;
 };
 
 // List of properties for a single file or a directory.
 typedef std::vector<Property> Properties;
 
+// Child response embedded in multipart parent response.
+struct MultipartHttpResponse {
+  MultipartHttpResponse();
+  ~MultipartHttpResponse();
+  DriveApiErrorCode code;
+  std::string body;
+};
+
+// Splits multipart |response| into |parts|. Returns true on succcess.
+// https://www.ietf.org/rfc/rfc2046.txt
+// The |response| should consists of multiple parts split by specific boundary
+// string. It looks like:

[kinaba, 2015/04/27 08:09:37]

In addition to the RFC, you are assuming that the "Content" part includes the
HTTP response header. It'll be better noted.

I also think that those detailed comments can be in the .cc file.
Here in .h, it is enough if it is mentioned that |response| is the HTTP response
body from Drive server as the reply of multipart request, and |parts| will be
the corresponding result of split.

[hirono, 2015/04/27 12:32:45]

Done.

+// --Boundary
+// Content-type: text/plain
+//
+// Content 1
+// --Boundary
+// Content-type: text/plain
+//
+// Content 2
+// --Boundary--
+bool ParseMultipartResponse(const std::string& boundary,
+                            const std::string& response,
+                            std::vector<MultipartHttpResponse>* parts);
+
 //============================ DriveApiPartialFieldRequest ====================
 
 // This is base class of the Drive API related requests. All Drive API requests
 // support partial request (to improve the performance). The function can be
 // shared among the Drive API requests.
 // See also https://developers.google.com/drive/performance
 class DriveApiPartialFieldRequest : public UrlFetchRequestBase {
  public:
   explicit DriveApiPartialFieldRequest(RequestSender* sender);
   ~DriveApiPartialFieldRequest() override;
@@ skipping 1049 matching lines @@
 
   // Obtains URLGenerator.
   const DriveApiUrlGenerator& url_generator() const { return url_generator_; }
 
   // UrlFetchRequestBase overrides.
   void Prepare(const PrepareCallback& callback) override;
   void Cancel() override;
   GURL GetURL() const override;
   net::URLFetcher::RequestType GetRequestType() const override;
   std::vector<std::string> GetExtraRequestHeaders() const override;
-  bool GetContentData(
-      std::string* upload_content_type,
-      std::string* upload_content) override;
+  bool GetContentData(std::string* upload_content_type,
+                      std::string* upload_content) override;
   void ProcessURLFetchResults(const net::URLFetcher* source) override;
   void RunCallbackOnPrematureFailure(DriveApiErrorCode code) override;
 
  private:
   typedef void* RequestID;
   // Obtains corresponding child entry of |request_id|. Returns NULL if the
   // entry is not found.
-  std::vector<BatchUploadChildEntry>::iterator
-  GetChildEntry(RequestID request_id);
+  std::vector<BatchUploadChildEntry>::iterator GetChildEntry(
+      RequestID request_id);
 
   // Called after child requests' |Prepare| method.
   void OnChildRequestPrepared(RequestID request_id, DriveApiErrorCode result);
 
   // Complete |Prepare| if possible.
   void MayCompletePrepare();
 
   // Process result for each child.
   void ProcessURLFetchResultsForChild(RequestID id, const std::string& body);
 
@@ skipping 14 matching lines @@
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<BatchUploadRequest> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BatchUploadRequest);
 };
 
 }  // namespace drive
 }  // namespace google_apis
 
 #endif  // GOOGLE_APIS_DRIVE_DRIVE_API_REQUESTS_H_