Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 108113006: Revert of Extract Certificate Transparency SCTs from stapled OCSP responses (Closed)

Created:
7 years ago by szym
Modified:
7 years ago
Reviewers:
ekasper, wtc, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@extract_scts
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/92443002/ Reason for revert: Does not compile on CrOS amd64 net/cert/ct_objects_extractor_nss.cc:528:66: error: narrowing conversion (...) from 'std::basic_string<char>::size_type {aka long unsigned int}' to 'unsigned int' inside { } is ill-formed in C++11 [-Werror=narrowing] ocsp_response.data())), ocsp_response.size() }; TBR=wtc@chromium.org,rsleevi@chromium.org,ekasper@google.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -1006 lines) Patch
M net/cert/ct_objects_extractor.h View 1 chunk +0 lines, -12 lines 0 comments Download
M net/cert/ct_objects_extractor_nss.cc View 8 chunks +8 lines, -343 lines 0 comments Download
M net/cert/ct_objects_extractor_openssl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/cert/ct_objects_extractor_unittest.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M net/cert/ct_verifier.h View 1 chunk +5 lines, -11 lines 0 comments Download
M net/cert/multi_log_ct_verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/multi_log_ct_verifier.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M net/cert/multi_log_ct_verifier_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket.h View 4 chunks +6 lines, -14 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 10 chunks +47 lines, -64 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 4 chunks +9 lines, -68 lines 0 comments Download
M net/test/ct_test_util.h View 1 chunk +0 lines, -12 lines 0 comments Download
M net/test/ct_test_util.cc View 2 chunks +0 lines, -69 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.h View 1 chunk +3 lines, -6 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M net/tools/testserver/testserver.py View 6 chunks +6 lines, -20 lines 0 comments Download
M third_party/tlslite/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/tlslite/patches/status_request.patch View 1 chunk +0 lines, -208 lines 0 comments Download
M third_party/tlslite/tlslite/TLSConnection.py View 7 chunks +7 lines, -22 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/tlslite/tlslite/messages.py View 6 chunks +0 lines, -53 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
szym
Created Revert of Extract Certificate Transparency SCTs from stapled OCSP responses
7 years ago (2013-12-13 20:22:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/108113006/1
7 years ago (2013-12-13 20:24:27 UTC) #2
commit-bot: I haz the power
7 years ago (2013-12-13 20:27:15 UTC) #3
Message was sent while issue was closed.
Change committed as 240731

Powered by Google App Engine
This is Rietveld 408576698