Issue 108113004: Merge 233843 "Ensure the wedge timer isn't started until after S..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108113004: Merge 233843 "Ensure the wedge timer isn't started until after S..." (Closed)

Created:
7 years ago by DaleCurtis

Modified:
7 years ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1700/src/

Visibility:
Public.

More Reviews

Description

Merge 233843 "Ensure the wedge timer isn't started until after S..." > Ensure the wedge timer isn't started until after StartStream(). > > Otherwise, in rare conditions, a very long StartStream() may > incorrectly cause a wedge to be flagged. > > If StartStream() hangs the message loop is blocked and the timer > will never run anyways. > > Also, increase wedge timer to 5 seconds. > > BUG=160920 > TEST=none > > Review URL: https://codereview.chromium.org/64493003 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240691

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	media/audio/audio_output_controller.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r240691.

Expand Messages | Collapse Messages