Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1081103009: Suppress TSAN for cc::VideoLayerImpl::WillDraw (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 7 months ago
CC:
chromium-reviews, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress TSAN for cc::VideoLayerImpl::WillDraw This function grabs locks in different orders depending on the order of the layers being drawn. But they are all released before being any are grabbed again, and more than one lock grab only occurs on the compositor thread. R=pbos@chromium.org,earthdok BUG=476529 Committed: https://crrev.com/6e85bb2fcfcee27c0bfb78e1492565e6dfe9f11b Cr-Commit-Position: refs/heads/master@{#327304}

Patch Set 1 #

Total comments: 1

Patch Set 2 : sup: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
danakj
5 years, 8 months ago (2015-04-23 22:26:56 UTC) #2
pbos
The CL description should read something like "acquiring more than one lock only ever happens ...
5 years, 8 months ago (2015-04-24 08:09:54 UTC) #3
danakj
PTAL
5 years, 8 months ago (2015-04-24 16:45:14 UTC) #4
danakj
ping?
5 years, 8 months ago (2015-04-24 20:11:36 UTC) #5
pbos
lgtm On Fri, Apr 24, 2015, 22:11 <danakj@chromium.org> wrote: > ping? > > https://codereview.chromium.org/1081103009/ > ...
5 years, 8 months ago (2015-04-24 21:32:27 UTC) #6
danakj
earthdok can you OWNERS?
5 years, 8 months ago (2015-04-24 21:33:16 UTC) #7
pbos
apparently, I'm not allowed to do that by email, lgtm
5 years, 8 months ago (2015-04-25 09:15:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081103009/20001
5 years, 8 months ago (2015-04-25 17:12:24 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-25 17:12:27 UTC) #12
Alexander Potapenko
On 2015/04/25 17:12:27, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 7 months ago (2015-04-28 06:14:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081103009/20001
5 years, 7 months ago (2015-04-28 16:46:05 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 16:53:32 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 16:54:17 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e85bb2fcfcee27c0bfb78e1492565e6dfe9f11b
Cr-Commit-Position: refs/heads/master@{#327304}

Powered by Google App Engine
This is Rietveld 408576698