Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1081103008: Update {virtual,override} to follow C++11 style in ui. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, yusukes+watch_chromium.org, tdresser+watch_chromium.org, jdduke+watch_chromium.org, shuchen+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, tfarina, kalyank, James Su, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in ui. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39 Cr-Commit-Position: refs/heads/master@{#326565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M ui/aura/window_tree_host_mac.h View 1 chunk +19 lines, -19 lines 0 comments Download
M ui/base/ime/chromeos/ime_keyboard_x11_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/models/tree_node_model.h View 4 chunks +12 lines, -12 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M ui/events/event_processor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/event_target_iterator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ncarter (slow)
avi: please look at this boring patch
5 years, 8 months ago (2015-04-23 04:32:42 UTC) #2
tfarina
Nothing against Avi as reviewer, but shouldn't you send this (ui/) to either Scott (sky) ...
5 years, 8 months ago (2015-04-23 08:27:59 UTC) #3
Avi (use Gerrit)
On 2015/04/23 08:27:59, tfarina wrote: > Nothing against Avi as reviewer, but shouldn't you send ...
5 years, 8 months ago (2015-04-23 14:58:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081103008/1
5 years, 8 months ago (2015-04-23 16:35:14 UTC) #6
ncarter (slow)
On 2015/04/23 08:27:59, tfarina wrote: > Nothing against Avi as reviewer, but shouldn't you send ...
5 years, 8 months ago (2015-04-23 16:54:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 17:38:18 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 17:39:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39
Cr-Commit-Position: refs/heads/master@{#326565}

Powered by Google App Engine
This is Rietveld 408576698