scripts/slave/recipe_modules/gpu/api.py - Issue 1081103005: Revert of Added GYP defines to dump linux symbols for gpu perf bots and trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/gpu/api.py

Issue 1081103005: Revert of Added GYP defines to dump linux symbols for gpu perf bots and trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/gpu/api.py

diff --git a/scripts/slave/recipe_modules/gpu/api.py b/scripts/slave/recipe_modules/gpu/api.py

index 8d6d3dc4f7df211ce86b5dd05fbe2995dd593b75..a621a9d180f0be50a08e80f0e8bff26745bc3c01 100644

--- a/scripts/slave/recipe_modules/gpu/api.py

+++ b/scripts/slave/recipe_modules/gpu/api.py

@@ -63,10 +63,6 @@

# bots).

self.m.chromium.c.gyp_env.GYP_DEFINES.pop('use_ash', None)

self.m.chromium.c.gyp_env.GYP_DEFINES.pop('use_aura', None)

- # To print out callstacks on linux bots, we must output symbols as well.

- if self.m.platform.is_linux:

- self.m.chromium.c.gyp_env.GYP_DEFINES['linux_dump_symbols'] = 1

# Enable archiving the GPU tests' isolates in chrome_tests.gypi.

# The non-GPU trybots build the "all" target, and these tests

« no previous file with comments | « scripts/slave/recipe_modules/chromium/config.py ('k') | scripts/slave/recipes/android/tester.py » ('j') | no next file with comments »