Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 1081103005: Revert of Added GYP defines to dump linux symbols for gpu perf bots and trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/gpu/api.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import pipes 5 import pipes
6 6
7 from slave.recipe_config import config_item_context, ConfigGroup 7 from slave.recipe_config import config_item_context, ConfigGroup
8 from slave.recipe_config import Dict, List, Single, Static, Set, BadConf 8 from slave.recipe_config import Dict, List, Single, Static, Set, BadConf
9 from slave.recipe_config_types import Path 9 from slave.recipe_config_types import Path
10 10
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 def _memory_tool(c, tool): 480 def _memory_tool(c, tool):
481 if tool not in MEMORY_TOOLS: # pragma: no cover 481 if tool not in MEMORY_TOOLS: # pragma: no cover
482 raise BadConf('"%s" is not a supported memory tool, the supported ones ' 482 raise BadConf('"%s" is not a supported memory tool, the supported ones '
483 'are: %s' % (tool, ','.join(MEMORY_TOOLS))) 483 'are: %s' % (tool, ','.join(MEMORY_TOOLS)))
484 c.runtests.memory_tool = tool 484 c.runtests.memory_tool = tool
485 485
486 @config_ctx() 486 @config_ctx()
487 def trybot_flavor(c): 487 def trybot_flavor(c):
488 fastbuild(c, optional=True) 488 fastbuild(c, optional=True)
489 dcheck(c, optional=True) 489 dcheck(c, optional=True)
490 linux_dump_symbols(c)
491 490
492 @config_ctx() 491 @config_ctx()
493 def gn_component_build(c): 492 def gn_component_build(c):
494 c.gn_args.append('is_component_build=true') 493 c.gn_args.append('is_component_build=true')
495 494
496 @config_ctx() 495 @config_ctx()
497 def gn_minimal_symbols(c): 496 def gn_minimal_symbols(c):
498 c.gn_args.append('symbol_level=1') 497 c.gn_args.append('symbol_level=1')
499 498
500 #### 'Full' configurations 499 #### 'Full' configurations
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
744 # Some of the binaries needed by the PGO gets copied into the build directory 743 # Some of the binaries needed by the PGO gets copied into the build directory
745 # during the build, we need to augment the PATH variable so it can find them 744 # during the build, we need to augment the PATH variable so it can find them
746 # during the profiling step. 745 # during the profiling step.
747 c.env.PATH.extend([c.build_dir.join(c.build_config_fs)]) 746 c.env.PATH.extend([c.build_dir.join(c.build_config_fs)])
748 747
749 @config_ctx(includes=['chromium_pgo_base']) 748 @config_ctx(includes=['chromium_pgo_base'])
750 def chromium_pgo_optimize(c): 749 def chromium_pgo_optimize(c):
751 c.gyp_env.GYP_DEFINES['chrome_pgo_phase'] = 2 750 c.gyp_env.GYP_DEFINES['chrome_pgo_phase'] = 2
752 751
753 @config_ctx() 752 @config_ctx()
754 def linux_dump_symbols(c):
755 if c.TARGET_PLATFORM == 'linux':
756 c.gyp_env.GYP_DEFINES['linux_dump_symbols'] = 1
757
758 @config_ctx()
759 def v8_optimize_medium(c): 753 def v8_optimize_medium(c):
760 c.gyp_env.GYP_DEFINES['v8_optimized_debug'] = 1 754 c.gyp_env.GYP_DEFINES['v8_optimized_debug'] = 1
761 c.gyp_env.GYP_DEFINES['v8_enable_slow_dchecks'] = 1 755 c.gyp_env.GYP_DEFINES['v8_enable_slow_dchecks'] = 1
762 756
763 @config_ctx() 757 @config_ctx()
764 def v8_verify_heap(c): 758 def v8_verify_heap(c):
765 c.gyp_env.GYP_DEFINES['v8_enable_verify_heap'] = 1 759 c.gyp_env.GYP_DEFINES['v8_enable_verify_heap'] = 1
766 760
767 @config_ctx() 761 @config_ctx()
768 def chromium_perf(c): 762 def chromium_perf(c):
769 c.compile_py.clobber = False 763 c.compile_py.clobber = False
770 764
771 @config_ctx() 765 @config_ctx()
772 def chromium_perf_fyi(c): 766 def chromium_perf_fyi(c):
773 c.compile_py.clobber = False 767 c.compile_py.clobber = False
774 if c.HOST_PLATFORM == 'win': 768 if c.HOST_PLATFORM == 'win':
775 c.compile_py.compiler = None 769 c.compile_py.compiler = None
776 c.compile_py.goma_dir = None 770 c.compile_py.goma_dir = None
777 c.gyp_env.GYP_DEFINES['use_goma'] = 0 771 c.gyp_env.GYP_DEFINES['use_goma'] = 0
778 772
779 @config_ctx() 773 @config_ctx()
780 def chromium_deterministic_build(c): 774 def chromium_deterministic_build(c):
781 c.gyp_env.GYP_DEFINES['dont_embed_build_metadata'] = 1 775 c.gyp_env.GYP_DEFINES['dont_embed_build_metadata'] = 1
782 776
783 @config_ctx(includes=['chromium_clang']) 777 @config_ctx(includes=['chromium_clang'])
784 def cast_linux(c): 778 def cast_linux(c):
785 c.gyp_env.GYP_DEFINES['chromecast'] = 1 779 c.gyp_env.GYP_DEFINES['chromecast'] = 1
786 c.compile_py.default_targets = ['cast_shell', 'cast_test_lists'] 780 c.compile_py.default_targets = ['cast_shell', 'cast_test_lists']
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/gpu/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698