content/renderer/media/media_stream_audio_processor_options.h - Issue 1081063003: [media_stream_audio_processor] Avoids updating UMA stats before AEC has valid results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_audio_processor_options.h

Issue 1081063003: [media_stream_audio_processor] Avoids updating UMA stats before AEC has valid results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/renderer/media/media_stream_audio_processor_options.cc » ('j') | content/renderer/media/media_stream_audio_processor_options.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_audio_processor_options.h

diff --git a/content/renderer/media/media_stream_audio_processor_options.h b/content/renderer/media/media_stream_audio_processor_options.h

index e5d0be5475b6d57de2d0266a7431fc4e6faa420a..8484b08cd37bde021a6a2bdb81830ffc5f14f77b 100644

--- a/content/renderer/media/media_stream_audio_processor_options.h

+++ b/content/renderer/media/media_stream_audio_processor_options.h

@@ -101,6 +101,7 @@ class CONTENT_EXPORT EchoInformation {

// Counter to track 5 seconds of processed 10 ms chunks in order to query a

// new metric from webrtc::EchoCancellation::GetEchoDelayMetrics().

int num_chunks_;

+ bool echo_frames_received_;

DISALLOW_COPY_AND_ASSIGN(EchoInformation);

};