Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 1081063003: [media_stream_audio_processor] Avoids updating UMA stats before AEC has valid results (Closed)

Created:
5 years, 8 months ago by bjornv
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[media_stream_audio_processor] Avoids updating UMA stats before AEC has valid results Stats are updated and logged continuously when echo cancellation is enabled. Being enabled is no guarantee for actually running since it, for example, is enabled by default when opening the microphone. All these invalid data clutter the UMA histogram. The improvement is a check for the first frame containing an echo state before start logging. This can only happen when the echo cancellation is actually running. BUG=450193 Committed: https://crrev.com/40d81fd5fea87aa63e82f1875e5874315ab215cf Cr-Commit-Position: refs/heads/master@{#326761}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed {} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M content/renderer/media/media_stream_audio_processor_options.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
bjornv
5 years, 8 months ago (2015-04-22 06:45:35 UTC) #2
tommi (sloooow) - chröme
lgtm % nit https://codereview.chromium.org/1081063003/diff/1/content/renderer/media/media_stream_audio_processor_options.cc File content/renderer/media/media_stream_audio_processor_options.cc (right): https://codereview.chromium.org/1081063003/diff/1/content/renderer/media/media_stream_audio_processor_options.cc#newcode235 content/renderer/media/media_stream_audio_processor_options.cc:235: if (!echo_frames_received_ & !echo_cancellation->stream_has_echo()) { no ...
5 years, 8 months ago (2015-04-23 14:35:35 UTC) #3
bjornv
Thanks for reviewing this. Now when perkj@ is on parental leave, you're the only webrtc ...
5 years, 8 months ago (2015-04-24 08:01:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081063003/20001
5 years, 8 months ago (2015-04-24 09:05:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 09:09:26 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 09:10:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40d81fd5fea87aa63e82f1875e5874315ab215cf
Cr-Commit-Position: refs/heads/master@{#326761}

Powered by Google App Engine
This is Rietveld 408576698