Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1081033005: Revert of Fix serialization of alias_for properties (Closed)

Created:
5 years, 8 months ago by tkent
Modified:
5 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@p7
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fix serialization of alias_for properties (patchset #3 id:40001 of https://codereview.chromium.org/1106443002/) Reason for revert: Broke multiple tests on Windows XP. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/18565 fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style.html svg/css/getComputedStyle-basic.xhtml transforms/webkit-perspective-parsing.html transitions/unprefixed-perspective.html transitions/unprefixed-transform.html virtual/stable/webexposed/css-properties-as-js-properties.html virtual/threaded/transitions/unprefixed-perspective.html virtual/threaded/transitions/unprefixed-transform.html webexposed/css-properties-as-js-properties.html Original issue's description: > Fix serialization of alias_for properties > > This fixes transition and will-change to properly serialize alias_for > properties instead of crashing. > > BUG=410112, 479441 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194351 TBR=alancutter@chromium.org,timloh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=410112, 479441 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M LayoutTests/transitions/transitions-parsing.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/transitions/transitions-parsing-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/build/scripts/make_css_property_names.py View 2 chunks +15 lines, -13 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Fix serialization of alias_for properties
5 years, 8 months ago (2015-04-24 09:46:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081033005/1
5 years, 8 months ago (2015-04-24 09:47:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194365
5 years, 8 months ago (2015-04-24 09:48:02 UTC) #3
tkent
5 years, 8 months ago (2015-04-24 09:52:16 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1105523005/ by tkent@chromium.org.

The reason for reverting is: Mistakenly reverted..

Powered by Google App Engine
This is Rietveld 408576698