Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1081033003: [x86] Allow (v)divsd->(v)mulsd to execute in parallel. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Allow (v)divsd->(v)mulsd to execute in parallel. This tweak was already present in CrankShaft for the non-AVX case. As it turns out, it's also relevant even with AVX. Now the same optimization is applied in case of TurboFan as well. R=dcarney@chromium.org Committed: https://crrev.com/e21f9ab42b90bb125380a62f2f54071a705bdf92 Cr-Commit-Position: refs/heads/master@{#27774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-13 08:02:32 UTC) #1
Benedikt Meurer
Hey Dan, This is straight forward port of the existing CS optimization. Please take a ...
5 years, 8 months ago (2015-04-13 08:03:19 UTC) #2
dcarney
lgtm do we know for which cpus this matters? instead of the comment, maybe something ...
5 years, 8 months ago (2015-04-13 08:11:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081033003/1
5 years, 8 months ago (2015-04-13 08:23:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 08:25:31 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 08:25:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e21f9ab42b90bb125380a62f2f54071a705bdf92
Cr-Commit-Position: refs/heads/master@{#27774}

Powered by Google App Engine
This is Rietveld 408576698