Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 108103002: DevTools: Remove unneeded willReceiveResourceData instrumentation and reuse didReceiveData instead … (Closed)

Created:
7 years ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
caseq, eustas, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

DevTools: Remove unneeded willReceiveResourceData instrumentation and reuse didReceiveData instead of didReceiveResourceData. R=eustas@chromium.org, pfeldman@chromium.org, caseq, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169647

Patch Set 1 #

Patch Set 2 : Fixed compilation #

Patch Set 3 : Rebaselined #

Patch Set 4 : Fixed #

Patch Set 5 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -27 lines) Patch
M Source/core/fetch/ResourceFetcher.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 2 3 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
vsevik
PTAL
7 years ago (2013-12-06 11:37:39 UTC) #1
pfeldman
lgtm
6 years, 10 months ago (2014-02-17 13:47:23 UTC) #2
eustas
lgtm superb
6 years, 10 months ago (2014-02-17 14:38:09 UTC) #3
pfeldman
ping
6 years, 9 months ago (2014-03-13 05:10:57 UTC) #4
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-20 07:46:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/108103002/150001
6 years, 9 months ago (2014-03-20 07:46:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 08:17:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-20 08:17:53 UTC) #8
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-20 08:25:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/108103002/150001
6 years, 9 months ago (2014-03-20 08:26:00 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 08:52:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 08:52:33 UTC) #12
vsevik
6 years, 9 months ago (2014-03-20 12:25:15 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 manually as r169647 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698