Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: sky/engine/web/WebLocalFrameImpl.cpp

Issue 1080993005: Fix display of 404s in SkyShell to show error text. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/web/WebLocalFrameImpl.cpp
diff --git a/sky/engine/web/WebLocalFrameImpl.cpp b/sky/engine/web/WebLocalFrameImpl.cpp
index e3a3c6f1b5ef98eafe637ae3317fe02301bb1ad4..99decb8f1af548b9d189110571be482109f1fb25 100644
--- a/sky/engine/web/WebLocalFrameImpl.cpp
+++ b/sky/engine/web/WebLocalFrameImpl.cpp
@@ -285,7 +285,9 @@ void WebLocalFrameImpl::OnReceivedResponse(mojo::URLResponsePtr response)
mojo::DataPipe pipe;
frame()->mojoLoader().parse(pipe.consumer_handle.Pass());
std::string error_response = base::StringPrintf(
- "<error><h>Empty Body</h><l>%d %s</l><m>%s</m></t></error>",
+ "<error><h style='display: paragraph'>Empty Body</h>"
+ "<l style='display: paragraph'>%d %s</l>"
+ "<m style='display: paragraph'>%s</m></t></error>",
response->status_code, response->status_line.get().c_str(),
response->error->description.get().c_str());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698