Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1080993005: Fix display of 404s in SkyShell to show error text. (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
Hixie, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix display of 404s in SkyShell to show error text. In MojoShell we never hit this path since the NetworkFetcher aborts earlier on, not knowing what content_handler to use. R=ojan@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/43e85d0ffbf8a7f714dd43afd65c022dfa7cbc25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
5 years, 8 months ago (2015-04-16 19:16:54 UTC) #1
ojan
lgtm
5 years, 8 months ago (2015-04-17 02:21:45 UTC) #3
Hixie
This suffers from cross-format injection. If you want to do it by constructing a string, ...
5 years, 8 months ago (2015-04-17 16:51:11 UTC) #4
eseidel
5 years, 8 months ago (2015-04-21 22:38:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
43e85d0ffbf8a7f714dd43afd65c022dfa7cbc25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698