ES6: Add Object.getOwnPropertySymbols

test/mjsunit/harmony/symbols.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 280 matching lines @@
 function TestKeyNames(obj) {
   assertEquals(0, Object.keys(obj).length)
 
   var names = Object.getOwnPropertyNames(obj)
   for (var i in names) {
     assertEquals("string", typeof names[i])
   }
 }
 
 
+function TestKeySymbols(obj) {

[rossberg, 2013/12/10 10:39:53]

Let's call this TestGetOwnPropertySymbols

[arv (Not doing code reviews), 2013/12/11 00:16:26]

Done.

+  var syms = Object.getOwnPropertySymbols(obj)
+  assertEquals(syms.length, symbols.length)
+  for (var i in syms) {
+    assertEquals("symbol", typeof syms[i])

[rossberg, 2013/12/10 10:39:53]

Also assert that insertion order is maintained (which implies that they are all
different).

And please add a test that ensures that inherited symbols are not included.

[arv (Not doing code reviews), 2013/12/11 00:16:26]

You sent me off on goose chase there. I finally figured out that we only use
insertion order when %HasFastProperties is true

Done.
Done.

[rossberg, 2013/12/12 15:37:59]

Ah, sorry about that. I should have known.

+  }
+}
+
+
 function TestKeyDescriptor(obj) {
   for (var i in symbols) {
     var desc = Object.getOwnPropertyDescriptor(obj, symbols[i]);
     assertEquals(i|0, desc.value)
     assertTrue(desc.configurable)
     assertEquals(i % 2 == 0, desc.writable)
     assertEquals(i % 2 == 0, desc.enumerable)
     assertEquals(i % 2 == 0,
         Object.prototype.propertyIsEnumerable.call(obj, symbols[i]))
   }
@@ skipping 13 matching lines @@
 var objs = [{}, [], Object.create(null), Object(1), new Map, function(){}]
 
 for (var i in objs) {
   var obj = objs[i]
   TestKeySet(obj)
   TestKeyDefine(obj)
   TestKeyGet(obj)
   TestKeyHas(obj)
   TestKeyEnum(obj)
   TestKeyNames(obj)
+  TestKeySymbols(obj)
   TestKeyDescriptor(obj)
   TestKeyDelete(obj)
 }
 
 
 function TestCachedKeyAfterScavenge() {
   gc();
   // Keyed property lookup are cached.  Hereby we assume that the keys are
   // tenured, so that we only have to clear the cache between mark compacts,
   // but not between scavenges.  This must also apply for symbol keys.
   var key = Symbol("key");
   var a = {};
   a[key] = "abc";
 
   for (var i = 0; i < 100000; i++) {
     a[key] += "a";  // Allocations cause a scavenge.
   }
 }
 TestCachedKeyAfterScavenge();
+
+
+function TestGetOwnPropertySymbolsWithPrivateSymbols() {

[rossberg, 2013/12/10 10:39:53]

Nit: Move this next to the other test.

[arv (Not doing code reviews), 2013/12/11 00:16:26]

I kept it here because this test does not take an obj like the other test. I
also added one more test down here so it feels less out of place.

+  var privateSymbol = %CreatePrivateSymbol("private")
+  var obj = {}

[rossberg, 2013/12/10 10:39:53]

Hm, the private symbol is never added to obj. ;)

Also, maybe have a mixture of both public and private symbols, and check that
insertion order still holds after non-trivial filtering.

[arv (Not doing code reviews), 2013/12/11 00:16:26]

Doh!

+  var syms = Object.getOwnPropertySymbols(obj)
+  assertEquals(syms.length, 0)
+}
+TestGetOwnPropertySymbolsWithPrivateSymbols()