Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 108083004: Improve ==/=== comparison in Hydrogen for monomorphic maps (Closed)

Created:
7 years ago by danno
Modified:
7 years ago
Reviewers:
titzer
CC:
v8-dev, Jakob Kummerow, Weiliang
Visibility:
Public.

Description

Improve ==/=== comparison in Hydrogen for monomorphic maps R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18357

Patch Set 1 #

Patch Set 2 : Fix nits #

Patch Set 3 : Optimize both compare variants #

Patch Set 4 : Final version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/hydrogen.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danno
PTAL
7 years ago (2013-12-06 11:24:48 UTC) #1
titzer
lgtm
7 years ago (2013-12-06 13:30:39 UTC) #2
danno
This has been languishing in our optimization stash for a while, landing...
7 years ago (2013-12-18 14:28:33 UTC) #3
danno
7 years ago (2013-12-18 17:18:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r18357 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698